Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect child specs for fsm sups #1066

Open
seancribbs opened this issue Feb 3, 2015 · 2 comments
Open

Incorrect child specs for fsm sups #1066

seancribbs opened this issue Feb 3, 2015 · 2 comments
Labels
Milestone

Comments

@seancribbs
Copy link

These child specs should be supervisors, not workers.

Thanks @DeadZen for finding this.

@kuenishi
Copy link
Contributor

kuenishi commented Feb 3, 2015

I believe it's harmless as the child_type is used only for which_children and count_children in supervisor. c.f. https://github.com/basho/otp/blob/otp-16b02-basho/lib/stdlib/src/supervisor.erl
Nonetheless, we'll care that.

@DeadZen
Copy link

DeadZen commented Feb 16, 2015

Cool, thanks @kuenishi / @seancribbs, Yes I see these are not harmful,
mostly out of the execution path, and probably would not turn up without
visual examination of the code. It may help tho to keep them from becoming
harmful if we mark them when one happens upon them. Btw, that was quick.
So, here's another one.. #1069 :)

On Tue, Feb 3, 2015 at 4:11 PM, UENISHI Kota notifications@github.com
wrote:

I believe it's harmless as the child_type is used only for which_children
and count_children in supervisor. c.f.
https://github.com/basho/otp/blob/otp-16b02-basho/lib/stdlib/src/supervisor.erl
Nonetheless, we'll care that.


Reply to this email directly or view it on GitHub
#1066 (comment).

@shino shino added the Bug label Jan 19, 2016
@kuenishi kuenishi added this to the 2.1.2 milestone Feb 10, 2016
@kuenishi kuenishi modified the milestones: 2.2.0, 2.1.2 Mar 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants