Disable previous riak object after back-pressure sleep is triggered #1041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is a good change to add spec to |
| case maybe_backpressure_sleep(riakc_obj:value_count(RiakObject)) of | ||
| true -> | ||
| %% Backpressure sleep is triggered. Bacause holding | ||
| %% previous object can lead to more siblings, discard it. |
There was a problem hiding this comment.
My comment recommendation is:
"Backpressure sleep has been triggered. Current manifests folded by this FSM is to be discarded to prevent unnecessary interleaving by other concurrent manifest updates while this sleep."
|
All riak_test has passed. Will run sibling explosion test tomorrow. |
When back-pressure sleep is triggered by many siblings, holding previous object can lead to more siblings. This commit change the behavior and discard it. This setting has effect only when all the following conditions are met: - Normal PUT Object, no effect for multipart upload - Overwring existing object, no effect for new object - read_before_last_manifest_write=false, this setting was introduced in CS 1.5.3 and default is true
shino
force-pushed
the
bugfix/disable-prev-after-backpressure-sleep
branch
from
1c9de96
to
2d68301
Compare
|
Thanks for review. |
|
Sibling explosion test result indicates that it endures twice more than before. Compare the number of lines until fail. Now working on bors, failing on PLT recreation. |
borshop
added a commit
that referenced
this pull request
Jan 11, 2015
…ssure-sleep Disable previous riak object after back-pressure sleep is triggered Reviewed-by: kuenishi
|
@borshop merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When back-pressure sleep is triggered by many siblings, holding
previous object can lead to more siblings. This commit change the
behaivior and discard it.
This setting has effect only when all the following conditions are met:
CS 1.5.3 and default is true
This PR addressed #1022 .