Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/disable prev after backpressure sleep 1.5 #1042

Merged
merged 2 commits into from
Jan 13, 2015

Conversation

shino
Copy link
Contributor

@shino shino commented Jan 13, 2015

Backport of #1041 to release/1.5 .

Original description (just copied) below


When back-pressure sleep is triggered by many siblings, holding
previous object can lead to more siblings. This commit change the
behaivior and discard it.

This setting has effect only when all the following conditions are met:

  • Normal PUT Object, no effect for multipart upload
  • Overwriting existing object, no effect for new object
  • read_before_last_manifest_write=false, this setting was introduced in
    CS 1.5.3 and default is true

This PR addressed #1022 .

When back-pressure sleep is triggered by many siblings, holding
previous object can lead to more siblings. This commit change the
behavior and discard it.

This setting has effect only when all the following conditions are met:
- Normal PUT Object, no effect for multipart upload
- Overwring existing object, no effect for new object
- read_before_last_manifest_write=false, this setting was introduced in
  CS 1.5.3 and default is true
@shino shino added this to the 1.5.4 milestone Jan 13, 2015
@shino shino added the Bug label Jan 13, 2015
borshop added a commit that referenced this pull request Jan 13, 2015
…ssure-sleep-1.5

Bugfix/disable prev after backpressure sleep 1.5

Reviewed-by: kuenishi
@shino
Copy link
Contributor Author

shino commented Jan 13, 2015

@borshop merge

@borshop borshop merged commit e05c17a into release/1.5 Jan 13, 2015
@shino shino deleted the bugfix/disable-prev-after-backpressure-sleep-1.5 branch January 13, 2015 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants