Return 500 instead of 403 when Riak is unavailable [JIRA: RCS-359] #1298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuenishi
force-pushed
the
ku/dont-403
branch
2 times, most recently
from
a8d9047
to
dab2ca7
Compare
kuenishi
changed the title
Need fix. |
|
create jira issue |
Basho-JIRA
changed the title
Basho-JIRA
added
JIRA: To Do
JIRA: PR Review
JIRA: In Progress
JIRA: Needs Review
and removed
JIRA: To Do
JIRA: In Progress
JIRA: Needs Review
labels
This commit adds new response 500 from an atom 'disconnected', which stems from Riak client error. The first call during request handling is fetching user information of requester via access key ID. It fails when Riak is unavailable by network partition or node being offline. Riak CS was handling this as authentication error thus returned 403. Regression tests are added in `regression_tests.erl` as a function, stopping all Riak nodes and trying S3 API requests to CS.
|
Now all riak_tests have passed. Ready for review. |
| Props = erlcloud_s3:get_object(BucketName, ?KEY, UserConfig), | ||
| ?assertEqual(proplists:get_value(content, Props), Data). | ||
| verify_cs756({UserConfig, {RiakNodes, _, _}}, BucketName) -> | ||
| %% Making sure API call from non-existent user all fails in 403, not 50x |
There was a problem hiding this comment.
This comment appears to say the exact opposite of what it should
|
Copyright dates should be updated in all changed files. |
|
Updated to comments; please take a look again. |
|
+1 722276e |
borshop
added a commit
that referenced
this pull request
Mar 21, 2016
Return 500 instead of 403 when Riak is unavailable [JIRA: RCS-359] Reviewed-by: tburghart
|
@borshop merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds new response 500 from an atom 'disconnected', which
stems from Riak client error. The first call during request handling
is fetching user information of requester via access key ID. It fails
when Riak is unavailable by network partition or node being offline.
Riak CS was handling this as authentication error thus returned 403.
Regression tests are added in
regression_tests.erlas a function,stopping all Riak nodes and trying S3 API requests to CS.
Rebased #1277 to latest
2.1