Patch/ignore gc manifest bad state 1.4.5 #841
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have seen this crash and prevent GC from finishing. Fixing the crash and adding a warning instead.
complementary to #827, this commit prevents Manifest's delete_block_remaining being undefined, after init/1 returns. Before prepare/2 very rarely but there could be a message that interrupts and moves to some invalid state. This also reduces number of states about delete_block_remaining being undefined or not.
|
Wontfix in 1.4.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #827 .
Once this is approved I'll copy this patch to develop branch. Or maybe I have to write
riak_cs_delete_fsm_eqcwith this chance. Thoughts?