add knob to disable referer check #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1, should help some customers where the referrer thing gets in the way and they already have adequete security. |
bsparrow435
pushed a commit
that referenced
this pull request
Oct 30, 2012
add knob to disable referer check
| @@ -235,7 +235,8 @@ any_to_bool(V) when is_boolean(V) -> | |||
| V. | |||
|
|
|||
| is_forbidden(RD) -> | |||
| is_null_origin(RD) or not is_valid_referer(RD). | |||
| is_null_origin(RD) or | |||
| (app_helper:get_env(riak_kv,secure_referer_check,true) and not is_valid_referer(RD)). | |||
There was a problem hiding this comment.
pretty sure you mean orelse and andalso here and not or and and
There was a problem hiding this comment.
You are absolutely correct.
Do you have an opinion on whether this setting should also disable the null
origin check?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.