Make index_hashtree process exit when related vnode exits #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a riak_kv_vnode exits, the associated riak_kv_index_hashtree should also shutdown because a future riak_kv_vnode process will try to create a new riak_kv_index_hashtree. If the old index_hashtree is still alive, it retains a lock to the LevelDB instance, causing the newer index_hashtree to fail endlessly when trying to open the LevelDB instance. This commit changes riak_kv_index_hashtree to monitor the associated riak_kv_vnode, shutting down if the riak_kv_vnode ever exits.
|
Well, the code looks good to me and I just ran this branch against the partition_repair test with the massive slaughter of kv nodes without the hashtree problems that happened before virtually all of the time. So I would say 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a riak_kv_vnode exits, the associated riak_kv_index_hashtree should also shutdown because a future riak_kv_vnode process will try to create a new riak_kv_index_hashtree. If the old index_hashtree is still alive, it retains a lock to the LevelDB instance, causing the newer index_hashtree to fail endlessly when trying to open the LevelDB instance.
This commit changes riak_kv_index_hashtree to monitor the associated riak_kv_vnode, shutting down if the riak_kv_vnode ever exits.