Maven build #15
Merged
Maven build #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added options to .proto files for java package and class names Created pom that currently builds source and binary jar files pom also creates CPP source and header files
…ve the release plugin, adjust the Makefile for releases.
If you have RELEASE_GPG_KEYNAME environment variable set the makefile will allow you to perform a java_release and maven will allow a deploy. If it's not set both make and maven will fail if you try to release/deploy
Conflicts: Makefile pom.xml
|
Wasn't happy with not being able to release. With some maven-foo and make conditionals this will now allow you to do a release to maven central including signing by setting the environment variable RELEASE_GPG_KEYNAME If it's not set neither make or mvn will allow you to release to maven central. |
|
Awesome, 👍 to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makefile will now execute java builds.
I left out the "release" beyond building because of the complexity (signing with keys, etc)