Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java POM changes for OSGI #25

Merged
merged 1 commit into from
Dec 20, 2012
Merged

Java POM changes for OSGI #25

merged 1 commit into from
Dec 20, 2012

Conversation

broach
Copy link
Contributor

@broach broach commented Dec 20, 2012

Will now add bundle information to MANIFEST in .jar

Also:
Removed unneeded dependencies.
Changed to use rotobuf-maven-plugin from maven central

Fixes #19

Will now add bundle information to MANIFEST in .jar

Also:
Removed unneeded dependencies.
Changed to use rotobuf-maven-plugin from maven central

Fixes #19
@seancribbs
Copy link

I see no problem with this, although I am not the expert on POM. 👍

@broach
Copy link
Contributor Author

broach commented Dec 20, 2012

Just as an FYI, It doesn't actually do much ... it changes the MANIFEST.MF in the .jar from:

Manifest-Version: 1.0
Archiver-Version: Plexus Archiver
Created-By: Apache Maven
Built-By: roach
Build-Jdk: 1.7.0_10

To:

Manifest-Version: 1.0
Bnd-LastModified: 1356022486792
Build-Jdk: 1.7.0_10
Built-By: roach
Bundle-Description: Protocol buffers used to communicate with Riak
Bundle-License: http://www.apache.org/licenses/LICENSE-2.0.txt
Bundle-ManifestVersion: 2
Bundle-Name: Riak Protocol Buffers
Bundle-SymbolicName: com.basho.riak.protobuf.riak-pb
Bundle-Version: 1.2.1
Created-By: Apache Maven Bundle Plugin
Export-Package: com.basho.riak.protobuf;uses:="com.google.protobuf";vers
ion="1.2.1"
Import-Package: com.google.protobuf
Tool: Bnd-1.50.0

broach pushed a commit that referenced this pull request Dec 20, 2012
@broach broach merged commit 2f36276 into master Dec 20, 2012
@seancribbs seancribbs deleted the gh19-java-osgi branch December 20, 2012 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants