Reduced Replication #402
Reduced Replication #402
Conversation
|
As a general comment, I think some more documentation would help other coders, particularly some context-giving doc. Such as, what is a kv mutator (links perhaps), how is it activated, how does this proxy_get wrapper get called, etc. I don't think in needs external doc, just a little context to what is already good doc in the repl_reduced module. |
| %% TCP buffers. | ||
| {diff_batch_size, 100} | ||
| ]} | ||
| ]}. |
There was a problem hiding this comment.
why was riak_repl.app.src changed?
There was a problem hiding this comment.
It did not exist before, so if one needs to add/remove a module to the repl application, you need to update ebin/riak_repl.app. By adding src/riak_repl.app.src the app file is automatically generated and updated as modules are added/removed.
The fact that I needed to update the .app file has bit me on other features before (cascading realtime), and this was the straw that broke the camel's back. My investigations indicated there was no good reason the for the .app file to be static, so I made it dynamically generated.
This is to help backwards compatibility.
Doesn't do proper mutation on get yet, and put mutation may not be perfect, but it's a start.
full_objects = always means always use full objects (never reduce). never is the opposite, and a number is how many full objects to keep.
riak_replRiak MDC Replication Pull Request templateTesting
Documentation
👍 |
| Self = self(), | ||
| case lists:nth(Nth, Preflist) of | ||
| {{_Partition, Self}, _PrimaryNess} -> | ||
| lager:debug("odd that we get ourselves as a pref. doing proxy"), |
There was a problem hiding this comment.
Odd, inconceivable, erroneous?
Repl part for #223 .
Adds a riak_kv_mutator callback that reduces objects to a minimal representation if set by either cluster or bucket; bucket always wins in case of reductions.