fixed rt sink and source conn to stop thier helpers in terminate. #652 [JIRA: RIAK-1476] #652
Conversation
Basho-JIRA
changed the title
| %% TODO: Consider trying to do something graceful with poolboy? | ||
| catch riak_repl2_rtsink_helper:stop(State#state.helper), |
There was a problem hiding this comment.
Why is this necessary? The rtsink_helper (and rtsource_helper) are both linked processes. As soon as the rtsource process terminates the associated helper should die with it.
There was a problem hiding this comment.
Normal exit of rtsink_conn is not being trapped by rtsink_helper. Another option is to set trap_exit at helpers?
There was a problem hiding this comment.
And the third option to exit with {shutdown, Reason} instead so you can tell why - but I think this terminate option is good for now.
|
Just heads up for @jonmeredith ^^; |
|
+1 232f1eb Sorry this languished so long. It's a good change. |
fixed rt sink and source conn to stop thier helpers in terminate. #652 [JIRA: RIAK-1476] Reviewed-by: jonmeredith
|
[~jmeredith] can you review/merge the related riak_test linked in the PR, and shepherd this through to the develop-2.2 branch? Or do we need to assign it to someone else? _[posted via JIRA by Douglas Rohrer]_ |
|
[~jmeredith]Does this one need to be assigned to someone else, per Doug's comment above? _[posted via JIRA by Patricia Brewer]_ |
|
It should be merged and merged forward. On Wed, Mar 9, 2016 at 3:44 PM Basho JIRA bot! notifications@github.com
|
|
Did I screw up merging this, or reporting it was merged? On Thu, Mar 10, 2016 at 6:13 AM Douglas Rohrer (JIRA) < _[posted via JIRA by Jon Meredith]_ |
|
Just didn't see the merge forward, and knew you were busy, so asked Brian to take over. Did you do the forward merge already? Doug _[posted via JIRA by Douglas Rohrer]_ |
|
I thought I did - it's easy for Sparrow to double-check - those :stop calls On Thu, Mar 10, 2016 at 7:45 AM Douglas Rohrer (JIRA) < _[posted via JIRA by Jon Meredith]_ |
|
resolves #649 |
this is intended for 2.0.5. It fixes #649 and allows basho/riak_test#722 to pass.