Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad code in several icons #33

Open
cyberalien opened this issue Sep 28, 2023 · 2 comments
Open

Bad code in several icons #33

cyberalien opened this issue Sep 28, 2023 · 2 comments
Assignees
Milestone

Comments

@cyberalien
Copy link

Several icons that use SVG animations have multiple elements with the same id:

  • /production/fill/svg/alert-avalanche-danger.svg has multiple elements with id="x"
  • /production/fill/svg/alert-falling-rocks.svg has multiple elements with id="x"
  • /production/line/svg/alert-avalanche-danger.svg has multiple elements with id="x"
  • /production/line/svg/alert-falling-rocks.svg has multiple elements with id="x"
  • /production/fill/svg/partly-cloudy-night-hail.svg has 2 symbols with id="i"

Last icon has 2 symbols with same id, other icons have multiple animations with same id. Symbols are used as clip paths, animations are used in timing of other animations, so those ids are actually used and probably used incorrectly.

@cyberalien
Copy link
Author

Few more icons with same bugs:

  • /production/line/svg/tornado.svg has multiple elements with id="x2" (unused, so not critical)
  • /production/line/svg/thunderstorms-rain.svg has multiple animations with id="x1"
  • /production/line/svg/thunderstorms-overcast-rain.svg has multiple animations with id="x1"
  • /production/line/svg/thunderstorms-night-rain.svg has multiple animations with id="x1"
  • /production/line/svg/thunderstorms-night-overcast-rain.svg has multiple animations with id="x1"
  • /production/line/svg/thunderstorms-night-extreme-rain.svg has multiple animations with id="x1"
  • /production/line/svg/thunderstorms-extreme-rain.svg has multiple animations with id="x1"
  • /production/line/svg/thunderstorms-day-rain.svg has multiple animations with id="x1"
  • /production/line/svg/thunderstorms-day-overcast-rain.svg has multiple animations with id="x1"
  • /production/line/svg/thunderstorms-day-extreme-rain.svg has multiple animations with id="x1"

For most of those icons, both fill and line versions are affected. I've listed only 1 variation.

@basmilius
Copy link
Owner

Hi sorry for the verry late answer, this will be fixed in the v3 milestone.

@basmilius basmilius self-assigned this Jun 30, 2024
@basmilius basmilius added this to the v3.0 milestone Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants