Feature/clipboard place holders #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add xclip to placeholders
Untested with GTK xclip semantics slightly changed to present contant tokens on invalid or non-textual clipboard content - this is probebly not the best thing - to think on.
First tests work - semantics are slightly different there appears to be a new-line at the end of the value, and the value has to be actively copied into the clipboard - i.e. CTRL-C - rather than just selected as is the case with xclip.
The original implementation via xclip was using the default clipboard - XA_PRIMARY - which is actually the current _selection_. The original gtk implementation was using SELECTION_CLIPBOARD - the content of the clipboard - i.e. the copied selection. To clear things up and make them both usable, I have left %v as the selection in both cases, and implemented %V as the copied selection.
Reliable escaping of clipboard content in general is still a bit hairy, but this at least makes it more consistent with the other place holders.
|
Hey there @supermerill So this is what I've come up with - I'd really appreciate you testing this to see if it fulfills the use cases you had in mind. I'm sure you know what to do, but just in case:
If you have further PRs for this feature, please submit against this branch, not master. And thx again for this excellent idea and the initial implementation! |
bassmanitram
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding placeholders that insert the textual content of the clipboard.
Courtesy of @supermerill.
This adds two new placeholders to the extension:
%vto insert the XA_PRIMARY selection content (think middle mouse button after selecting text)%Vto insert the XA_CLIPBOARD selection content (think CTRL-V of CTRL-C'd text)(For more info on the X selection categories, see the manual pages for clipboard management programs such as
xclipboard,xclip,xsel,xcutsel...)If the selected text contains quotes, parameter quoting may be corrupted, so these should be used carefully.
Hopefully, we'll address parameter quoting in general in a future PR to alleviate these issues.