shell completion issue

[chenrui333]

While packaging for homebrew, I ran into some shell completion issue as below:

~ basti completion zsh
basti <command>

Commands:
  basti init                  Initialize a target to use with Basti                                                                                [aliases: i]
  basti connect [connection]  Start port forwarding session with the selected target                                                               [aliases: c]
  basti cleanup               Remove all resources created by Basti                                                                               [aliases: cl]
  basti completion            Generate completion script for your shell

Options:
  -h, --help     Show help                                                                                                                            [boolean]
  -v, --version  Show version number                                                                                                                  [boolean]

Examples:
  basti init     Initialize a target in interactive mode
  basti connect  Start connection in interactive mode
  basti cleanup  Cleanup Basti resources in interactive mode (requires confirmation)

Did you mean cl?
➜  ~ echo $?
1

Log an issue in here for visibility.

[BohdanPetryshyn]

Hey @chenrui333, thank you for your work on the homebrew formula! ❤️

Basti uses the yargs library which doesn't expect any additional arguments for the completion command. So the following commands will return exactly the same output:

1. basti completion zsh
2. basti completion anything
3. basti completion

Can the supported basti completion command be used in brew instead of removing the recommendations?

[chenrui333]

Can the supported basti completion command be used in brew instead of removing the recommendations?

it simply does not work, based on what I see, there is not much use of recommendCommands

[BohdanPetryshyn]

Just to clarify, do you mean that basti completion doesn't work or basti completion zsh doesn't work?

The value of the recommendCommands functionality is questionable indeed so if removing it will help in the Homebrew formula creation, we can do this.

[chenrui333]

Just to clarify, do you mean that basti completion doesn't work or basti completion zsh doesn't work?

if you do SHELL=zsh basti completion zsh, that does not work.

And SHELL=zsh basti completion bash still outputs bash completion, which is wrong

The value of the recommendCommands functionality is questionable indeed so if removing it will help in the Homebrew formula creation, we can do this.

yeah, let's remove that, I dont see any values of it. People can either do help or just tldr to see the manual

[BohdanPetryshyn]

According to the yargs docs, the completion command doesn't expect any additional arguments. I can see that the output of the basti completion command changes according to the SHELL env variable:

1. SHELL=zsh basti completion - outputs completion for zsh
2. SHELL=bash basti completion - outputs completion for bash

Please, note the absence of any arguments after the completion command. Can the command be used without additional arguments like zsh or bash in Homebrew?

[chenrui333]

adopted like that SHELL=zsh basti completion, and it fixed my issue. thanks!