Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Character Traits Excess Information #76

Closed
shadowfray opened this issue Dec 5, 2021 · 4 comments
Closed

Character Traits Excess Information #76

shadowfray opened this issue Dec 5, 2021 · 4 comments
Assignees
Labels

Comments

@shadowfray
Copy link

The character sheet area for traits has some extra lines which seem like they're not supposed to be there. Here is a screenshot. As well, the active skills seem to suffer a similar problem. If these are intentional, could there be a way to hide them to make it more legible?

@Bathtor
Copy link
Owner

Bathtor commented Dec 5, 2021

Crap, looks like something about the way Roll20 handles internationalisation changed. It's showing the i18n key for the text instead of the localised value.

I'll try to find some time to fix it next weekend.

@Bathtor Bathtor added the bug label Dec 5, 2021
@Bathtor Bathtor self-assigned this Dec 5, 2021
@Bathtor
Copy link
Owner

Bathtor commented Dec 11, 2021

Ok, I've spent the day looking into this (and a bunch of other new issues with the sheet stemming from dependency updates).

I've reproduced it in a fairly minimal sheet, at it seems that the Roll20 Sheet feature that allows lookups of translation keys based on a field value is currently broken in general.
It was reported for the Shaped sheet as well here: https://app.roll20.net/forum/post/10510203/shaped-character-sheet-issue
And I personally checked Roll20's official D&D 5E sheet and it seems broken there, too. Just the translation key happens to be basically the same as the value in English there, so it's not so bothersome.

I'll give Roll20 a week to reply and let me know if/when they are planning to fix this.
If I don't get a helpful answer by then, I think it can be worked around by using sheet workers, so I may explore that option next weekend instead.

@Bathtor
Copy link
Owner

Bathtor commented Dec 19, 2021

Yeah, nothing helpful from Roll20, except "We filed an internal ticket".
So I guess I gotta work around this myself.
Don't have time today, though. Will try to schedule it somewhere over the holidays.

@Bathtor
Copy link
Owner

Bathtor commented Dec 30, 2021

Found a workaround. It's in v1.14.0 (files attached there).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants