Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All languages #20

Open
nicolas-raoul opened this issue May 28, 2016 · 4 comments
Open

All languages #20

nicolas-raoul opened this issue May 28, 2016 · 4 comments

Comments

@nicolas-raoul
Copy link
Collaborator

15 languages have implemented listings: https://www.wikidata.org/wiki/Q14330485#sitelinks-wikivoyage
Many have wikidata or wikipedia properties, meaning that they can be useful for cross-validation, for instance.
Some are a bit difficult to understand (for instance Hebrew), but we can ask at their café or at https://meta.wikimedia.org/wiki/Wikivoyage/Lounge

@cafeina-software
Copy link
Contributor

I couldn't find anywhere here and in the website linked what's required to a Wikivoyage language edition and what to code, to add a language to your system.

Could you please tell me what to do?

@nicolas-raoul
Copy link
Collaborator Author

nicolas-raoul commented Feb 20, 2018

It is actually quite simple, even if you are a Java beginner:

  1. Fork and clone the Github repository.
  2. Go to https://github.com/baturin/wikivoyage-listings/tree/master/src/main/java/org/wikivoyage/listings/language and find the language whose markup is the most similar to yours.
  3. Then copy/paste the language's package (and its content) and rename to your language.
  4. Finally, add your language at https://github.com/baturin/wikivoyage-listings/blob/master/src/main/java/org/wikivoyage/listings/language/Languages.java#L19

Then compile, test, and send us a pull request. In a second phase you can try to tweak things a bit for your language's specificities, but please send the pull request first if the result is usable. Thanks! :-)

@cafeina-software
Copy link
Contributor

The elitist world of programmers... In README it plainly says "Requirements: Java, Gradle". But for normal people without much skills in computing this is rude. You have to be more kind and offer at least links to the required dependencies and how to install them as easy as possible. And also how to configure and build them.

You assumed I know Java when I don't know much about it. I did changes as you told me and as I could following my limited knowledge in C. But after running successfully "gradlew jar", the second command "wikivoyage-listings.sh" couldn't work, as it's a UNIX shell script but I'm working on Windows NT.

I tried to run the code within the shell, "java -Xmx1024m -cp "wikivoyage-listings.jar:build/libs/wikivoyage-listings.jar:lib/*:config/" org.wikivoyage.listings.Main", but it said org.wikivoyage.listings.Main couldn't be found. I ran it with console focus in the root folder of the repo. "C:.......\wikivoyage-listings".

@nicolas-raoul
Copy link
Collaborator Author

Indeed we don't have much Windows knowledge, so without knowing we might take things for granted that are not granted. Thanks for letting us know! :-)
If you find something that can be explained better, don't hesitate to send us a modified README file, thanks a lot!
Could you please try to create a .bat file from the .sh file? I don't know the syntax but I believe it is rather similar. Please send us the modified file if it works.
Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants