Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project should not depend on dotnetcore version of HTML Agility Pack. #66

Closed
idvorkin opened this issue Sep 24, 2017 · 3 comments
Closed

Project should not depend on dotnetcore version of HTML Agility Pack. #66

idvorkin opened this issue Sep 24, 2017 · 3 comments
Assignees
@baynezy
Labels
feature A new business feature request A request for a new feature or enhancement

Comments

@idvorkin
Copy link

Html2Markdown/src/Html2Markdown/Html2Markdown.csproj

Line 14 in ee4fd5b

<PackageReference Include="HtmlAgilityPack.NetCore" Version="1.5.0.1" />

When I tried to use the dot net standard version, I saw a unit test break on:

 Convert_ComplexTest_002 [0:00.034] Failed: System.Exception : Multiple node elments can't be created.
 System.Exception : Multiple node elments can't be created.

Do you have more context you can share?
@baynezy baynezy added feature A new business feature request A request for a new feature or enhancement labels Sep 28, 2017
@baynezy
Copy link
Owner

baynezy commented Sep 28, 2017

When I upgraded this to work with .Net Core HAP had not been upgraded. I can take a look at changing back to HAP as that supports both.

@baynezy
Copy link
Owner

baynezy commented Sep 28, 2017

See zzzprojects/html-agility-pack#13

@baynezy baynezy added the ready label Sep 28, 2017
@baynezy
Copy link
Owner

baynezy commented Sep 29, 2017

Look at https://stackoverflow.com/a/42787747/1003830 when implementing

baynezy added a commit that referenced this issue Sep 29, 2017
@baynezy
Swap HtmlAgilityPack.Core for HtmlAgilityPack
6be22b8 
This previously required the Core version of HtmlAgilityPack
this is no longer necessary as the main project is now
portable.

Closes #66
@ghost ghost assigned baynezy Sep 29, 2017
@ghost ghost added in progress and removed ready labels Sep 29, 2017
@baynezy baynezy added next release Completed work that is yet to be deployed and removed in progress labels Sep 30, 2017
@ghost ghost removed the next release Completed work that is yet to be deployed label Sep 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@baynezy baynezy

Labels
feature A new business feature request A request for a new feature or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@idvorkin @baynezy