Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rules_swift] override tarball deps to either use .zip or source checkouts #650

Closed
jerrymarino opened this issue Jan 30, 2023 · 3 comments
Closed

Comments

@jerrymarino
Copy link
Contributor

There's an ongoing issue with tarballs on github: https://github.com/orgs/community/discussions/45830 and rules_swift points at many of the non-release URLs:

ERROR: An error occurred during the fetch of repository 'com_github_apple_swift_log':
ERROR: An error occurred during the fetch of repository 'com_github_apple_swift_nio_http2':
ERROR: An error occurred during the fetch of repository 'com_github_apple_swift_nio':
ERROR: An error occurred during the fetch of repository 'com_github_grpc_grpc_swift':
ERROR: An error occurred during the fetch of repository 'com_github_apple_swift_protobuf':
ERROR: An error occurred during the fetch of repository 'six':
ERROR: An error occurred during the fetch of repository 'com_github_apple_swift_nio_extras':
ERROR: An error occurred during the fetch of repository 'com_github_apple_swift_nio_transport_services':

We can use the zip URLs as a stopgap until there is a conclusion about what the resolution is - or just leave them as a zip. It isn't clear if they'll provide taballs back.

In rules/repositories.bzl - we should declare the depenecies upstream of rules_swift for now

@jerrymarino
Copy link
Contributor Author

This was the offical comms from github that indicates they won't revert it:
bazel-contrib/SIG-rules-authors#11 (comment)

@thiagohmcruz
Copy link
Contributor

plot twist, revert on the way: bazel-contrib/SIG-rules-authors#11 (comment)

@jerrymarino
Copy link
Contributor Author

Yep, the nice thing is that moving to either zips or source is that it'd work in the case of this - though with github actively mitigating this I think it's probably file to close out for now and come up with a better plan longer term

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants