Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZstdCompression] Read request with offset incorrectly fails with not_found error and removes blob #1757

Closed
amishra-u opened this issue Jun 6, 2024 · 0 comments · Fixed by #1758

Comments

@amishra-u
Copy link
Contributor

Bug

When Bazel sends a read request with a non-zero offset and the compression flag set, the read request incorrectly fails with a not_found error.

Why

When a read request has a non-zero offset, it attempts to skip the specified number of bytes in the input stream. However, the skip functionality is not implemented for ZstdCompressingInputStream, which results in an IOException. This IOException is incorrectly classified as not_found. As a result, the blob location is removed from the backplane, causing the subsequent read requests for same digest also fails with a not_found error in the same build where the action cache check has already been completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant