Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deleted feature from config file #203

Merged
merged 1 commit into from
Dec 4, 2018
Merged

Conversation

ob
Copy link
Contributor

@ob ob commented Dec 4, 2018

9455445 removed the requeue_on_failure config option but left it in the examples. If you just try to naively use the example, it fails with an exception.

For now, just remove the config line, but the error message could be better.

Exception in thread "main" com.google.protobuf.TextFormat$ParseException: 69:1: Input contains unknown fields and/or extensions:
69:1:	build.buildfarm.v1test.WorkerConfig.requeue_on_failure
	at com.google.protobuf.TextFormat$Parser.checkUnknownFields(TextFormat.java:1405)
	at com.google.protobuf.TextFormat$Parser.merge(TextFormat.java:1428)
	at com.google.protobuf.TextFormat$Parser.merge(TextFormat.java:1364)
	at com.google.protobuf.TextFormat$Parser.merge(TextFormat.java:1334)
	at com.google.protobuf.TextFormat.merge(TextFormat.java:1213)
	at build.buildfarm.worker.operationqueue.Worker.toWorkerConfig(Worker.java:515)
	at build.buildfarm.worker.operationqueue.Worker.main(Worker.java:543)

Copy link
Collaborator

@werkt werkt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, thanks!

@werkt werkt merged commit 83797ce into bazelbuild:master Dec 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants