-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: It is impossible to bump compatibility level if you mutually depend on another module. #2232
Comments
Possible solution:
rules_proto only cares about the most backwards portable pieces of rules_pkg, so it would set Another solution: Or that the compatibilty_level of anything specified in the project MODULE.bazel wins in favor of any explicit versions called out transitively. Maybe that happens in general, but not if the compat level is in the |
We already have this: https://bazel.build/rules/lib/globals/module#bazel_dep.max_compatibility_level |
OK. That is half the battle. But the problem remains that I have to modify rules_proto to push my new version of rules_pkg. That is a lot of friction. |
Well, yes... I don't know what your expected outcome is. If you upload a version of At the end of the day, incrementing the compatibility level of your module is a big deal. Bazel's default here is to be safe and disallow multiple compatibility levels to coexist -- the other alternatives are bad in their own ways. |
* Revert compatibility_level back to 1 so we can push to BCR. See bazelbuild/bazel-central-registry#2232 for discussion. * update version#
Closing as this doesn't seem actionable -- we can reopen if you have other suggestions. |
This is actionable. We could change the repository update to be able to
ignore bzlmod loops that don't matter.
…On Tue, Jul 23, 2024 at 6:37 PM Xùdōng Yáng ***@***.***> wrote:
Closing as this doesn't seem actionable -- we can reopen if you have other
suggestions.
—
Reply to this email directly, view it on GitHub
<#2232 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXHHHFN7OM4ECYPBETDL6TZN3LJZAVCNFSM6AAAAABJE4OUPWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBWGQZDGMZUHA>
.
You are receiving this because you authored the thread.Message ID:
<bazelbuild/bazel-central-registry/issues/2232/2246423348
***@***.***>
|
What happened?
Trying to add rules_pkg/1.0.0, which bumps compatibility_level.
Presubmit fails:
So, the obvious problem with enforcing this
Version
How to reproduce
Any other information?
No response
The text was updated successfully, but these errors were encountered: