-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rules_pkg 1.0.1 (was 1.0.0) #2180
Conversation
Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (rules_pkg) have been updated in this PR. Please review the changes. |
ping @aiuto |
checks are red |
I have no idea how to fix what is broken.
So, the obvious problem with enforcing this
Opened #2232 to track solutions. |
Sigh. Each test requires a new release of rules_pkg because MODULE.bazel in this repo must match what is in the download file. The error explains that.
|
Instead of releasing rules_pkg, you can just apply the prospective fixes here as patches. Once it's green you can either submit this entry with the patches, or bake those patches into rules_pkg for one release cycle you already know will pass. |
This is not a true dependency. We do it to fake out the transitive dependency checking for compatibility. What we really want is the dependency from rules_python to win.
Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (rules_pkg) have been updated in this PR. Please review the changes. |
Add rules_pkg 1.0.1
1.0.0 was a failed attempt because of a dependency loop.