You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When a BUILD file needs to be fixed, gazelle fix just emits a warning without explaining what's wrong with it. This could be something as trivial as loaded symbols being out of order.
Our warning should explain what needs to be fixed. We should not emit a warning for trivial problems that won't interfere with later operations (loaded symbol ordering).
The text was updated successfully, but these errors were encountered:
* FixFile and FixLoads now modify a file in place instead of returning
a new file. This simplifies the implementation of current and future
transformations, since it avoids the need to copy objects which
aren't easily copied.
* FixFile is consolidated with FixFileMinor. Risky transformations are
only performed if c.ShouldFix is true. Warnings are printed
otherwise.
Fixesbazelbuild#150Fixesbazelbuild#58
* FixFile and FixLoads now modify a file in place instead of returning
a new file. This simplifies the implementation of current and future
transformations, since it avoids the need to copy objects which
aren't easily copied.
* FixFile is consolidated with FixFileMinor. Risky transformations are
only performed if c.ShouldFix is true. Warnings are printed
otherwise.
Fixes#150Fixes#58
Migrated from bazelbuild/rules_go#792
When a BUILD file needs to be fixed,
gazelle fix
just emits a warning without explaining what's wrong with it. This could be something as trivial as loaded symbols being out of order.Our warning should explain what needs to be fixed. We should not emit a warning for trivial problems that won't interfere with later operations (loaded symbol ordering).
The text was updated successfully, but these errors were encountered: