Gazelle fix should explain what is wrong #792
Comments
jayconrod
pushed a commit
to jayconrod/rules_go
that referenced
this issue
Sep 8, 2017
fixLoads is now called in MergeWithExisting instead of FixLoads. This will remove symbols that are no longer needed after empty rules are deleted. This also eliminates warnings that files need to be fixed if they only need load changes. Related bazel-contrib#792
jayconrod
added a commit
that referenced
this issue
Sep 12, 2017
fixLoads is now called in MergeWithExisting instead of FixLoads. This will remove symbols that are no longer needed after empty rules are deleted. This also eliminates warnings that files need to be fixed if they only need load changes. Related #792
|
Migrated to bazel-contrib/bazel-gazelle#58 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When a BUILD file needs to be fixed,
gazelle fixjust emits a warning without explaining what's wrong with it. This could be something as trivial as loaded symbols being out of order.Our warning should explain what needs to be fixed. We should not emit a warning for trivial problems that won't interfere with later operations (loaded symbol ordering).
The text was updated successfully, but these errors were encountered: