Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gazelle may not delete empty go_binary rules #59

Closed
jayconrod opened this issue Dec 27, 2017 · 1 comment
Closed

Gazelle may not delete empty go_binary rules #59

jayconrod opened this issue Dec 27, 2017 · 1 comment
Labels
bug

Comments

@jayconrod
Copy link
Contributor

Migrated from bazel-contrib/rules_go#890

Gazelle deletes a rule if the only attributes left after merging are name and visibility. If you remove all binary sources, then add library sources and run Gazelle again, the go_binary rule will be left with importpath and library attributes.
@jayconrod jayconrod added the bug label Dec 27, 2017
@jayconrod jayconrod mentioned this issue Dec 27, 2017
Closed
@jayconrod
Copy link
Contributor Author

Fixed by #90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jayconrod