Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gazelle doesn't update build files when all sources are removed #61

Closed
jayconrod opened this issue Dec 27, 2017 · 0 comments
Closed

Gazelle doesn't update build files when all sources are removed #61

jayconrod opened this issue Dec 27, 2017 · 0 comments
Labels
bug

Comments

@jayconrod
Copy link
Contributor

jayconrod commented Dec 27, 2017 •
edited
Loading

Migrated from bazel-contrib/rules_go#939

Gazelle should remove all rules in the build file that it may have generated. Other rules should be left intact. If the build file is empty after removing rules, it should NOT be deleted.
@jayconrod jayconrod added the bug label Dec 27, 2017
@jayconrod jayconrod mentioned this issue Dec 27, 2017
Closed
jayconrod pushed a commit to jayconrod/bazel-gazelle that referenced this issue Feb 2, 2018
cmd/gazelle: delete rules in directories which have no source files
2421341 
Gazelle will now delete Go and proto rules from build files for
directories which no longer have buildable source files (because the
files were removed, excluded, or ignored).

Note: this also causes Gazelle to apply buildifier formatting in build
files it was asked to update but didn't previously touch.

Fixes bazel-contrib#61
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jayconrod