Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix partial execution with mapped kinds #1680

Merged
merged 1 commit into from
Dec 19, 2023

Commits on Dec 19, 2023

  1. Fix partial execution with mapped kinds

    Previously, if mapped kinds were in use (i.e. `go_library` -> `go_custom_library`),
    and `gazelle update` was being run on just one directory, Gazelle's
    indexing system would fail to correctly index build rules of the mapped-to
    kind in directories that were not being re-built.
    
    This is because the logic to handle mapped kinds was triggered only when
    Generate() was run, not for Imports().
    
    This PR solves the issue with the smallest fix. The whole kind-mapping
    system is honestly kinda messy, and I didn't want to propose a major
    refactor.
    eric-skydio authored and fmeum committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    06f2410 View commit details
    Browse the repository at this point in the history