-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Directories from glob are not marked as is_directory #12954
Comments
I got bit by this today too. It is not just from glob, it happens with explicit paths to directories as well. Is there any chance of bumping this up from P4? |
This directory expansion in args as well. Currently, if you want to use a directory, it has to come as the output of a rule. |
Correct. The correct title of this issue is "Source directories are not marked as is_directory" I know that source directories aren't really supported in Bazel. I was using them for efficient processing of hundreds of npm dependencies. There isn't really a great alternative. |
Thank you for contributing to the Bazel repository! This issue has been marked as stale since it has not had any activity in the last 1+ years. It will be closed in the next 90 days unless any other activity occurs. If you think this issue is still relevant and should stay open, please post any comment here and the issue will no longer be marked as stale. |
Comment |
Description of the problem / feature request:
Directories included from glob using
exclude_directories = 0
do not correctly returnTrue
for File.is_directory.Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.
Running
bazel build ...
with the following files will reproduce this issue.BUILD.bazel
rule.bzl
dir/file.txt
# This is a file in a directory
WORKSPACE.bazel
What operating system are you running Bazel on?
MacOS/Linux
What's the output of
bazel info release
?release 4.0.0
Any other information, logs, or outputs that you want to share?
Note that
<source file dir> is source
from the output below is incorrect. It's a directory.<source file dir> is directory
(or something to this effect, hitting theelse
condition inrule.bzl
) should have been printed.The text was updated successfully, but these errors were encountered: