-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No lock files for bzlmod
modules
#14554
Comments
This is already on the roadmap. Bzlmod will support a lockfile prior to official launch. (Unclear whether we should leave this issue open -- @meteorcloudy wdyt?) |
I think we can leave this issue open to track the progress of lock file implementation. |
Is this still on the roadmap? |
Definitely, @SalmaSamy is working on this |
@SalmaSamy Are you planning to have this go through the regular Bazel proposal process? |
@fmeum Yes, we will share the proposal draft soon. |
The Bzlmod lockfile proposal is available at https://docs.google.com/document/d/1HPeH_L-lRK54g8A27gv0q7cbk18nwJ-jOq_14XEiZdc/edit#heading=h.5mcn15i0e1ch |
Looks like this just landed 3b9ec35 Minor nit, is there a way the contents could be formatted? Right now it's hard to diff since it's 1 giant line |
Also when building the second time after having created the file I get this exception:
|
Hi @keith, A change is made to format the file. |
I tried this out and while I didn't run into the exception reported by @keith, I noticed a few issues. Let me know if you would like me to move them to separate issues. Readability improved a lot with the last commit, thanks for that!
|
@fmeum @Wyverald @SalmaSamy |
I'm ambivalent between MODULE.bazel.lock and MODULE.lock.bazel. Either is okay IMO :) |
I'm slightly in favor of |
I do like I'm not completely sure whether I like it more than a name that doesn't involve |
I am also okay with @fmeum Can you explain more what you mean by "it 'locks' the current module rather than all other modules"? |
@fmeum Regarding the other issues:
Thanks! |
The In this sense the Bzlmod lock file will in the future pin more than just the resolved contents of all |
Yeah, I guess no matter what name we choose, eventually experienced users will understand what it is for. The difference is basically which one is more friendly to beginner users, and for that I still prefer |
The name is updated to |
The flag has been updated to match the document. @fmeum Can you please provide a reproducible scenario for point number 1, and how do you know that resolution was rerun? |
@SalmaSamy I cannot reproduce anymore (I just checked for internet access to the registry before). Looks pretty good now! |
@fmeum I see. |
This has mostly landed on master and will be in 6.3.0. Closing. |
Description of the problem / feature request:
Although the algorithm used by
bzlmod
should lead to stable results, having to recalculate the dependency tree with each build is wasteful and may prevent reproducible builds, particularly of historic commits. TheWORKSPACE
file locked everything down, so there was no need to worry about this, but it would be useful ifbzlmod
had a lock file it could (optionally) use.Feature requests: what underlying problem are you trying to solve with this feature?
I want reproducible builds, even if someone has yanked a module since the last build.
What's the output of
bazel info release
?release 5.0.0rc3
The text was updated successfully, but these errors were encountered: