Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Errors for Transitive Rules #15791

Open
aryeh-looker opened this issue Jul 2, 2022 · 8 comments
Open

Improve Errors for Transitive Rules #15791

aryeh-looker opened this issue Jul 2, 2022 · 8 comments
Labels
not stale Issues or PRs that are inactive but not considered stale P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) team-Configurability platforms, toolchains, cquery, select(), config transitions type: feature request

Comments

@aryeh-looker
Copy link
Contributor

Description of the feature request:

improve errors in transitive rules

what we get:

ERROR: /usr/local/google/home/aryehh/Development/cloud-spanner-emulator/binaries/BUILD:23:10: While resolving toolchains for target //binaries:emulator_main: invalid registered toolchain '@rules_foreign_cc//tools/build_defs/shell_toolchain/toolchains:linux_commands': error loading package '@rules_foreign_cc//tools/build_defs/shell_toolchain/toolchains': at /usr/local/google/home/aryehh/.cache/bazel/_bazel_aryehh/432487528c3e0374d8bae32ea74d9eb8/external/rules_foreign_cc/tools/build_defs/shell_toolchain/toolchains/defs.bzl:6:6: at /usr/local/google/home/aryehh/.cache/bazel/_bazel_aryehh/432487528c3e0374d8bae32ea74d9eb8/external/commands_overloads/toolchain_data_defs.bzl:3:6: compilation of module 'windows_commands.bzl' failed

what might be more ideal:

ERROR: /usr/local/google/home/aryehh/Development/cloud-spanner-emulator/binaries/BUILD:23:10: While resolving toolchains for target //binaries:emulator_main: invalid registered toolchain
  '@rules_foreign_cc//tools/build_defs/shell_toolchain/toolchains:linux_commands': error loading package 
    '@rules_foreign_cc//tools/build_defs/shell_toolchain/toolchains':
      at /usr/local/google/home/aryehh/.cache/bazel/_bazel_aryehh/432487528c3e0374d8bae32ea74d9eb8/external/rules_foreign_cc/tools/build_defs/shell_toolchain/toolchains/defs.bzl:6:6:
      at /usr/local/google/home/aryehh/.cache/bazel/_bazel_aryehh/432487528c3e0374d8bae32ea74d9eb8/external/commands_overloads/toolchain_data_defs.bzl:3:6: compilation of module 'windows_commands.bzl' failed

or something similar

What underlying problem are you trying to solve with this feature?

Understanding the dependency graph when an error in a rule happens

Which operating system are you running Bazel on?

glinux

What is the output of bazel info release?

release 5.2.0

If bazel info release returns development version or (@non-git), tell us how you built Bazel.

No response

What's the output of git remote get-url origin; git rev-parse master; git rev-parse HEAD ?

No response

Have you found anything relevant by searching the web?

No response

Any other information, logs, or outputs that you want to share?

No response

@aryeh-looker
Copy link
Contributor Author

Repro is to clone https://github.com/GoogleCloudPlatform/cloud-spanner-emulator and attempt to build with bazel 5.2.0

@sgowroji
Copy link
Member

sgowroji commented Jul 4, 2022

Hello @aryeh-looker, Thank you for providing the above details. Can you provide exact steps to reproduce the above errors. Thanks!

@sgowroji
Copy link
Member

Hello @aryeh-looker, Could you please provide steps to reproduce the above errors. Thanks!

@sgowroji
Copy link
Member

We are marking the above Issue as stale because it has not had any recent activity from many days.
It will be closed in 7 days if there is no further activity occurs. Thank you.

@sgowroji
Copy link
Member

sgowroji commented Aug 4, 2022

Closing as it is stale. Please reach us back if you still looking resolution for the above request or open a new issue adding the above as reference.

@sgowroji sgowroji closed this as completed Aug 4, 2022
@fmeum
Copy link
Collaborator

fmeum commented Aug 4, 2022

@sgowroji I think that this issue is still valid. It isn't tied to a particular project, it's just about better error messages. @gregestren who I think has an ongoing project for more beautiful error messages.

@sgowroji sgowroji reopened this Aug 4, 2022
@sgowroji sgowroji added type: feature request team-Configurability platforms, toolchains, cquery, select(), config transitions untriaged and removed more data needed labels Dec 3, 2022
@gregestren
Copy link
Contributor

See #11984. Sadly prioritizing low for now...

@gregestren gregestren added P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) and removed untriaged labels Feb 15, 2023
Copy link

Thank you for contributing to the Bazel repository! This issue has been marked as stale since it has not had any activity in the last 1+ years. It will be closed in the next 90 days unless any other activity occurs. If you think this issue is still relevant and should stay open, please post any comment here and the issue will no longer be marked as stale.

@github-actions github-actions bot added the stale Issues or PRs that are stale (no activity for 30 days) label Apr 21, 2024
@fmeum fmeum added not stale Issues or PRs that are inactive but not considered stale and removed stale Issues or PRs that are stale (no activity for 30 days) labels Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not stale Issues or PRs that are inactive but not considered stale P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) team-Configurability platforms, toolchains, cquery, select(), config transitions type: feature request
Projects
None yet
Development

No branches or pull requests

4 participants