Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should test bazel fetch ... on a clean repository #1886

Closed
damienmg opened this issue Oct 5, 2016 · 3 comments
Closed

We should test bazel fetch ... on a clean repository #1886

damienmg opened this issue Oct 5, 2016 · 3 comments
Assignees
Labels
category: misc > testing P2 We'll consider working on this in future. (Assignee optional) type: bug
Milestone

Comments

@damienmg
Copy link
Contributor

damienmg commented Oct 5, 2016

See #1880 for more context.

@damienmg damienmg added type: bug P2 We'll consider working on this in future. (Assignee optional) category: misc > testing labels Oct 5, 2016
@damienmg damienmg added this to the 0.5 milestone Oct 5, 2016
@kchodorow
Copy link
Contributor

I don't understand what test case you think is missing. We had a bunch of integration tests for fetch. fetch+android stuff?

@aj-michael
Copy link
Contributor

Yes, we should put an android_binary in one of the fetch integration tests.

#1880 happened because tensorflow has an android_binary as a sample app and I accidentally introduced an implicit dependency from android_binary on something from the android_sdk_repository. So bazel fetch tensorflow/... failed inside ./configure if you didn't have an android_sdk_repository in the WORKSPACE.

@kchodorow kchodorow assigned aj-michael and unassigned kchodorow Jan 5, 2017
@aj-michael
Copy link
Contributor

bazel fetch //some/android:target will intentionally fail without an android_sdk_repository set up in the WORKSPACE as of 0b9ebfe. See #1819 (comment) for context on this decision. Tensorflow's use case was cleaned up in tensorflow/tensorflow#6225.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: misc > testing P2 We'll consider working on this in future. (Assignee optional) type: bug
Projects
None yet
Development

No branches or pull requests

3 participants