Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.5.0] Optimize prefetchInputs. #20562

Closed
bazel-io opened this issue Dec 15, 2023 · 3 comments
Closed

[6.5.0] Optimize prefetchInputs. #20562

bazel-io opened this issue Dec 15, 2023 · 3 comments
Milestone
6.5.0 release blo...

Comments

@bazel-io
Copy link
Member

Forked from #20557
@bazel-io bazel-io added this to the 6.5.0 release blockers milestone Dec 15, 2023
@bazel-io
Copy link
Member Author

bazel-io commented Jan 2, 2024

Cherry-pick was attempted, but there may be merge conflict(s). Please resolve manually.
cc: @bazelbuild/triage

@iancha1992
Copy link
Member

@coeuvre @brentleyjones @tjgq There were two conflicting files when trying to cherry-pick this to 6.5.0 (7.1.0 was cherry-pickable just fyi)

  1. src/test/java/com/google/devtools/build/lib/remote/ActionInputPrefetcherTestBase.java
  2. src/main/java/com/google/devtools/build/lib/remote/AbstractActionInputPrefetcher.java

Could you please take a look?

cc: @bazelbuild/triage

@coeuvre
Copy link
Member

coeuvre commented Jan 4, 2024

I tried manually cherry-pick the commit but it required non-trivial code change to make the commit compatible with 6.5.0. Let's not take the risk of accidentally breaking Bazel 6.x.

@coeuvre coeuvre closed this as completed Jan 4, 2024
@iancha1992 iancha1992 closed this as not planned Won't fix, can't repro, duplicate, stale Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.5.0 release blockers
Development

No branches or pull requests
3 participants
@coeuvre @bazel-io @iancha1992