Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of precompiled C++ libraries #3402

Closed
hlopko opened this issue Jul 18, 2017 · 1 comment
Closed

Improve handling of precompiled C++ libraries #3402

hlopko opened this issue Jul 18, 2017 · 1 comment
Assignees
Labels
P1 I'll work on this now. (Assignee required) type: feature request

Comments

@hlopko
Copy link
Member

hlopko commented Jul 18, 2017

Right now users can put precompiled libraries into cc_library.srcs attribute. This has some limitations, namely:

  • It's not possible to link such library as whole-archive (well, in a sane way)
  • It's not possible to group libraries into lib-groups
  • There's no way of specifying if the library is static or dynamic, only the file extension is checked, which causes trouble on Windows with their .lib libraries.
  • People use cc_library.srcs approach so cc_library can depend on cc_binary, but don't realize the consequences.

Solution might be a new rule, cc_import, that will provide support for all of above, with nice documentation explaining what can happen (diamonds).

Related: #70, #3323

@hlopko hlopko self-assigned this Jul 18, 2017
@hlopko hlopko added category: rules > C++ P2 We'll consider working on this in future. (Assignee optional) type: feature request labels Jul 18, 2017
@hlopko hlopko added this to the 0.8 milestone Jul 18, 2017
@hlopko
Copy link
Member Author

hlopko commented Aug 2, 2017

Feel free to comment on a design doc for this issue.

@hlopko hlopko added P1 I'll work on this now. (Assignee required) and removed P2 We'll consider working on this in future. (Assignee optional) labels Nov 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 I'll work on this now. (Assignee required) type: feature request
Projects
None yet
Development

No branches or pull requests

2 participants