Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temp directories: respect TMPDIR/TEMP/TMP for local actions #4376

Closed
laszlocsomor opened this issue Jan 2, 2018 · 1 comment
Closed

Temp directories: respect TMPDIR/TEMP/TMP for local actions #4376

laszlocsomor opened this issue Jan 2, 2018 · 1 comment
Assignees
@laszlocsomor
Labels
P1 I'll work on this now. (Assignee required) platform: windows type: feature request

Comments

@laszlocsomor
Copy link
Contributor

laszlocsomor commented Jan 2, 2018 •
edited

Request

Respect the user's TMPDIR envvar (or TMP and TEMP on Windows) if set, fall back on /tmp on Linux/macOS and to temp-in-execroot on Windows.

Summary

Unexpected effect of cfccdf1 was that it breaks socket creation because the paths are longer than 106 characters.

From https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=847206:

I can confirm that this is the case -- the GNUPGHOME needs to fit within
sockaddr_un.sun_path (see unix(7)). In other test suites that use
GnuPG, i've seen deliberately short paths used.

/cc @jianglai, @jmhodges

Context
@laszlocsomor laszlocsomor self-assigned this Jan 2, 2018
@laszlocsomor laszlocsomor added P1 I'll work on this now. (Assignee required) type: feature request windows-q1-2018-maybe labels Jan 2, 2018
bazel-io pushed a commit that referenced this issue Jan 4, 2018
@laszlocsomor
Extract LocalEnvProvider members to classes.
a495bae 
Create a PosixLocalEnvProvider and
WindowsLocalEnvProvider class, with singleton
instances for now.

This refactoring should not change functionality,
it's just a requirement for an upcoming change.

That upcoming change is for these classes to
respect the client environment's TMPDIR or
TMP/TEMP envvars.

See #4376

Change-Id: I032bb6f18adf8af9e43e6bc543c09c58adae3863
PiperOrigin-RevId: 180799936
bazel-io pushed a commit that referenced this issue Jan 5, 2018
@laszlocsomor
action_temp_test: eliminate for-loop
be27c0a 
Refactor the test not to use a for-loop to iterate
over the strategies. This way it's easier to see
from the failure stack trace which strategy it was
exactly that failed.

This is preparation for #4376

Change-Id: I2004b58957c823701c2d68682e7d8b78e80c834a
PiperOrigin-RevId: 180911370
bazel-io pushed a commit that referenced this issue Jan 8, 2018
@laszlocsomor
actions: don't add the server's TMPDIR to the env
294c074 
The BazelConfiguration no longer adds the Bazel
server process' TMPDIR/TMP/TEMP environment
variables.

I added that code before having implemented always
creating a temp directory for actions:
cfccdf1

See #4376

Change-Id: I8ba63d6120a0aa849997b274fb2d68ad50b2285c
PiperOrigin-RevId: 181134179
@ulfjack ulfjack mentioned this issue Jan 10, 2018
Closed
bazel-io pushed a commit that referenced this issue Jan 11, 2018
@laszlocsomor
sandbox: properly add tmpDir to writablePaths
2e631c9 
When Bazel creates the sandbox for an action,
Bazel collects a set of paths that the action may
write to.

The action needs write access to its temp
directory, so Bazel needs to add it to the
writable paths.

See #4376

Change-Id: Ifd3c482aa67ff8a2070045356abad8b39c808db8
PiperOrigin-RevId: 181591520
jmhodges added a commit to jmhodges/bazel_bugs that referenced this issue Jan 15, 2018
@jmhodges
okay try bazel at f2075d27ca
72006e8 
Has the commits that close out bazelbuild/bazel#4376
which is related to bazelbuild/bazel#4303
@jmhodges jmhodges mentioned this issue Jan 15, 2018
Closed
iirina pushed a commit that referenced this issue Jan 24, 2018
@laszlocsomor @iirina
sandbox: properly add tmpDir to writablePaths
422e9ec 
When Bazel creates the sandbox for an action,
Bazel collects a set of paths that the action may
write to.

The action needs write access to its temp
directory, so Bazel needs to add it to the
writable paths.

See #4376

Change-Id: Ifd3c482aa67ff8a2070045356abad8b39c808db8
PiperOrigin-RevId: 181591520
iirina pushed a commit that referenced this issue Jan 24, 2018
@laszlocsomor @iirina
actions,temp: respect TMPDIR envvar
37676f1 
Fixes #4376

Change-Id: Id78bb0930044626304e54f07735db4d4b2c84720
PiperOrigin-RevId: 181959528
iirina pushed a commit that referenced this issue Jan 26, 2018
@laszlocsomor @iirina
sandbox: properly add tmpDir to writablePaths
9d0d811 
When Bazel creates the sandbox for an action,
Bazel collects a set of paths that the action may
write to.

The action needs write access to its temp
directory, so Bazel needs to add it to the
writable paths.

See #4376

Change-Id: Ifd3c482aa67ff8a2070045356abad8b39c808db8
PiperOrigin-RevId: 181591520
iirina pushed a commit that referenced this issue Jan 26, 2018
@laszlocsomor @iirina
actions,temp: respect TMPDIR envvar
bfc738d 
Fixes #4376

Change-Id: Id78bb0930044626304e54f07735db4d4b2c84720
PiperOrigin-RevId: 181959528
iirina pushed a commit that referenced this issue Jan 26, 2018
@laszlocsomor @iirina
sandbox: properly add tmpDir to writablePaths
25189f1 
When Bazel creates the sandbox for an action,
Bazel collects a set of paths that the action may
write to.

The action needs write access to its temp
directory, so Bazel needs to add it to the
writable paths.

See #4376

Change-Id: Ifd3c482aa67ff8a2070045356abad8b39c808db8
PiperOrigin-RevId: 181591520
iirina pushed a commit that referenced this issue Jan 26, 2018
@laszlocsomor @iirina
actions,temp: respect TMPDIR envvar
2bcd60c 
Fixes #4376

Change-Id: Id78bb0930044626304e54f07735db4d4b2c84720
PiperOrigin-RevId: 181959528
iirina pushed a commit that referenced this issue Jan 30, 2018
@laszlocsomor @iirina
sandbox: properly add tmpDir to writablePaths
d373a3c 
When Bazel creates the sandbox for an action,
Bazel collects a set of paths that the action may
write to.

The action needs write access to its temp
directory, so Bazel needs to add it to the
writable paths.

See #4376

Change-Id: Ifd3c482aa67ff8a2070045356abad8b39c808db8
PiperOrigin-RevId: 181591520
iirina pushed a commit that referenced this issue Jan 30, 2018
@laszlocsomor @iirina
actions,temp: respect TMPDIR envvar
1272813 
Fixes #4376

Change-Id: Id78bb0930044626304e54f07735db4d4b2c84720
PiperOrigin-RevId: 181959528
iirina pushed a commit that referenced this issue Jan 30, 2018
@laszlocsomor @iirina
sandbox: properly add tmpDir to writablePaths
32a185b 
When Bazel creates the sandbox for an action,
Bazel collects a set of paths that the action may
write to.

The action needs write access to its temp
directory, so Bazel needs to add it to the
writable paths.

See #4376

Change-Id: Ifd3c482aa67ff8a2070045356abad8b39c808db8
PiperOrigin-RevId: 181591520
iirina pushed a commit that referenced this issue Jan 30, 2018
@laszlocsomor @iirina
actions,temp: respect TMPDIR envvar
44da7d9 
Fixes #4376

Change-Id: Id78bb0930044626304e54f07735db4d4b2c84720
PiperOrigin-RevId: 181959528
iirina pushed a commit that referenced this issue Feb 12, 2018
@laszlocsomor @iirina
sandbox: properly add tmpDir to writablePaths
f2a9936 
When Bazel creates the sandbox for an action,
Bazel collects a set of paths that the action may
write to.

The action needs write access to its temp
directory, so Bazel needs to add it to the
writable paths.

See #4376

Change-Id: Ifd3c482aa67ff8a2070045356abad8b39c808db8
PiperOrigin-RevId: 181591520
iirina pushed a commit that referenced this issue Feb 12, 2018
@laszlocsomor @iirina
actions,temp: respect TMPDIR envvar
04f19e3 
Fixes #4376

Change-Id: Id78bb0930044626304e54f07735db4d4b2c84720
PiperOrigin-RevId: 181959528
jianglai added a commit to google/nomulus that referenced this issue Feb 20, 2018
@jianglai
Respect system TMPDIR in GPG related tests
7f2e369 
With bazelbuild/bazel#4376, bazel 0.10.0 now supports accessing system TMPDIR in its sandbox. Use this instead of hardcoding /tmp in BUILD rules to get around the gpg-agent path length restriction.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=186010932
werkt pushed a commit to werkt/bazel that referenced this issue Mar 2, 2018
@laszlocsomor
Extract LocalEnvProvider members to classes.
8890c6f 
Create a PosixLocalEnvProvider and
WindowsLocalEnvProvider class, with singleton
instances for now.

This refactoring should not change functionality,
it's just a requirement for an upcoming change.

That upcoming change is for these classes to
respect the client environment's TMPDIR or
TMP/TEMP envvars.

See bazelbuild#4376

Change-Id: I032bb6f18adf8af9e43e6bc543c09c58adae3863
PiperOrigin-RevId: 180799936
werkt pushed a commit to werkt/bazel that referenced this issue Mar 2, 2018
@laszlocsomor
action_temp_test: eliminate for-loop
34cad35 
Refactor the test not to use a for-loop to iterate
over the strategies. This way it's easier to see
from the failure stack trace which strategy it was
exactly that failed.

This is preparation for bazelbuild#4376

Change-Id: I2004b58957c823701c2d68682e7d8b78e80c834a
PiperOrigin-RevId: 180911370
werkt pushed a commit to werkt/bazel that referenced this issue Mar 2, 2018
@laszlocsomor
actions: don't add the server's TMPDIR to the env
19f1c37 
The BazelConfiguration no longer adds the Bazel
server process' TMPDIR/TMP/TEMP environment
variables.

I added that code before having implemented always
creating a temp directory for actions:
bazelbuild@cfccdf1

See bazelbuild#4376

Change-Id: I8ba63d6120a0aa849997b274fb2d68ad50b2285c
PiperOrigin-RevId: 181134179
werkt pushed a commit to werkt/bazel that referenced this issue Mar 2, 2018
@laszlocsomor
sandbox: properly add tmpDir to writablePaths
5b26de1 
When Bazel creates the sandbox for an action,
Bazel collects a set of paths that the action may
write to.

The action needs write access to its temp
directory, so Bazel needs to add it to the
writable paths.

See bazelbuild#4376

Change-Id: Ifd3c482aa67ff8a2070045356abad8b39c808db8
PiperOrigin-RevId: 181591520
werkt pushed a commit to werkt/bazel that referenced this issue Mar 2, 2018
@laszlocsomor
actions,temp: respect TMPDIR envvar
864f632 
Fixes bazelbuild#4376

Change-Id: Id78bb0930044626304e54f07735db4d4b2c84720
PiperOrigin-RevId: 181959528
hridder pushed a commit to hridder/nomulus that referenced this issue Mar 6, 2018
@jianglai @hridder
Respect system TMPDIR in GPG related tests
feabeff 
With bazelbuild/bazel#4376, bazel 0.10.0 now supports accessing system TMPDIR in its sandbox. Use this instead of hardcoding /tmp in BUILD rules to get around the gpg-agent path length restriction.

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=186010932
@dapirian
Copy link

dapirian commented Jun 1, 2021

I believe this has had the side effect that --test_env=TMPDIR=/tmp is not respected, which is problematic

luca-digrazia pushed a commit to luca-digrazia/DatasetCommitsDiffSearch that referenced this issue Sep 4, 2022
sandbox: properly add tmpDir to writablePaths
02b3a0d 
    When Bazel creates the sandbox for an action,
    Bazel collects a set of paths that the action may
    write to.

    The action needs write access to its temp
    directory, so Bazel needs to add it to the
    writable paths.

    See bazelbuild/bazel#4376

    Change-Id: Ifd3c482aa67ff8a2070045356abad8b39c808db8
    PiperOrigin-RevId: 181591520
luca-digrazia pushed a commit to luca-digrazia/DatasetCommitsDiffSearch that referenced this issue Sep 4, 2022
actions: don't add the server's TMPDIR to the env
7c4f2da 
    The BazelConfiguration no longer adds the Bazel
    server process' TMPDIR/TMP/TEMP environment
    variables.

    I added that code before having implemented always
    creating a temp directory for actions:
    bazelbuild/bazel@cfccdf1

    See bazelbuild/bazel#4376

    Change-Id: I8ba63d6120a0aa849997b274fb2d68ad50b2285c
    PiperOrigin-RevId: 181134179
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laszlocsomor laszlocsomor

Labels
P1 I'll work on this now. (Assignee required) platform: windows type: feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hlopko @dapirian @laszlocsomor