Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollback to JDK 9 breaks tests relying on java.log #6098

Closed
lberki opened this issue Sep 7, 2018 · 6 comments
Closed

Rollback to JDK 9 breaks tests relying on java.log #6098

lberki opened this issue Sep 7, 2018 · 6 comments
Assignees
@tetromino
Labels
area-Windows Windows-specific issues and feature requests breakage P2 We'll consider working on this in future. (Assignee optional) platform: windows team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website

Comments

@lberki
Copy link
Contributor

lberki commented Sep 7, 2018

In particular, test_cache_computed_file_digests_behavior and test_log_file_uses_single_line_formatter.

Disabling these for now. It seems to be a fallout of the revamp of the server logging infrastructure.
@lberki
Copy link
Contributor Author

lberki commented Sep 7, 2018

/cc @tetromino @laszlocsomor

@lberki lberki added P2 We'll consider working on this in future. (Assignee optional) breakage platform: windows area-Windows Windows-specific issues and feature requests labels Sep 7, 2018
@lberki
Copy link
Contributor Author

lberki commented Sep 7, 2018

/cc @cushon @laurentlb @philwo

@laszlocsomor
Copy link
Contributor

Apparently bazel built off HEAD does not write $(bazel info output_base)/java.log on Windows. I'm debugging now why.

@laszlocsomor
Copy link
Contributor

repro branch: https://github.com/laszlocsomor/bazel/tree/lukacs-experimental and laszlocsomor@102b615

@philwo
Copy link
Member

philwo commented Sep 7, 2018

Ah - interesting. Sorry about the wrong link to #6064! This indeed looks like a different issue.

@laszlocsomor
Copy link
Contributor

Related: #6099

laszlocsomor added a commit to laszlocsomor/bazel that referenced this issue Sep 7, 2018
@laszlocsomor
Windows: fix writing java.log
2113484 
Fixes bazelbuild#6099
Fixes bazelbuild#6098
Related to bazelbuild#2576

Change-Id: Iabff91cca715d08e2977234e8615b2e0bf8a5dbc
@laszlocsomor laszlocsomor mentioned this issue Sep 7, 2018
Closed
laurentlb pushed a commit that referenced this issue Sep 10, 2018
@laszlocsomor @laurentlb
Windows: fix writing java.log
089cc3b 
Fixes #6099
Fixes #6098
Related to #2576

Change-Id: Iabff91cca715d08e2977234e8615b2e0bf8a5dbc

Closes #6100.

Change-Id: Ib55e01b5a82315d2a5f1a861f56079013d1cfec8
PiperOrigin-RevId: 211983456
laurentlb pushed a commit that referenced this issue Sep 10, 2018
@laszlocsomor @laurentlb
Windows: fix writing java.log
25bb0b7 
Fixes #6099
Fixes #6098
Related to #2576

Change-Id: Iabff91cca715d08e2977234e8615b2e0bf8a5dbc

Closes #6100.

Change-Id: Ib55e01b5a82315d2a5f1a861f56079013d1cfec8
PiperOrigin-RevId: 211983456
laurentlb pushed a commit that referenced this issue Sep 12, 2018
@laszlocsomor @laurentlb
Windows: fix writing java.log
dc62fbf 
Fixes #6099
Fixes #6098
Related to #2576

Change-Id: Iabff91cca715d08e2977234e8615b2e0bf8a5dbc

Closes #6100.

Change-Id: Ib55e01b5a82315d2a5f1a861f56079013d1cfec8
PiperOrigin-RevId: 211983456
laurentlb pushed a commit that referenced this issue Sep 12, 2018
@laszlocsomor @laurentlb
Windows: fix writing java.log
58d9399 
Fixes #6099
Fixes #6098
Related to #2576

Change-Id: Iabff91cca715d08e2977234e8615b2e0bf8a5dbc

Closes #6100.

Change-Id: Ib55e01b5a82315d2a5f1a861f56079013d1cfec8
PiperOrigin-RevId: 211983456
@philwo philwo added the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tetromino tetromino

Labels
area-Windows Windows-specific issues and feature requests breakage P2 We'll consider working on this in future. (Assignee optional) platform: windows team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tetromino @philwo @lberki @laszlocsomor