Windows: fix writing java.log #6100
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes bazelbuild#6099 Fixes bazelbuild#6098 Related to bazelbuild#2576 Change-Id: Iabff91cca715d08e2977234e8615b2e0bf8a5dbc
|
This patch also fixes the uncaught exception in |
lberki
reviewed
Sep 7, 2018
src/main/cpp/util/path_windows.cc
Outdated
| // See https://github.com/bazelbuild/bazel/issues/2576 and | ||
| // https://github.com/bazelbuild/bazel/issues/6098 | ||
| std::string::size_type pos = 0; | ||
| while (true) { |
There was a problem hiding this comment.
Isn't this quadratic? Mind you, not that the strings in question are very long (cue PATH_MAX), but if there is a simple way...
There was a problem hiding this comment.
You're fully right. Let me fix that.
Change-Id: Ie2afe0b44c9f54f1339bb4850fa5c3a1dc61c4e0
lberki
approved these changes
Sep 7, 2018
Change-Id: Ib55e01b5a82315d2a5f1a861f56079013d1cfec8
laurentlb
pushed a commit
that referenced
this pull request
Sep 10, 2018
laurentlb
pushed a commit
that referenced
this pull request
Sep 10, 2018
laurentlb
pushed a commit
that referenced
this pull request
Sep 12, 2018
laurentlb
pushed a commit
that referenced
this pull request
Sep 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6099
Fixes #6098
Related to #2576
Change-Id: Iabff91cca715d08e2977234e8615b2e0bf8a5dbc