Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incompatible_remove_cpu_and_compiler_attributes_from_cc_toolchain #7075

Closed
hlopko opened this issue Jan 10, 2019 · 6 comments
Closed

incompatible_remove_cpu_and_compiler_attributes_from_cc_toolchain #7075

hlopko opened this issue Jan 10, 2019 · 6 comments
Assignees
@hlopko
Labels
incompatible-change Incompatible/breaking change P2 We'll consider working on this in future. (Assignee optional) team-Rules-CPP Issues for C++ rules

Comments

@hlopko
Copy link
Member

hlopko commented Jan 10, 2019 •
edited
Loading

Flag: --incompatible_remove_cpu_and_compiler_attributes_from_cc_toolchain
Available since: 0.23 (February 2019 release)
Will be flipped in: 0.24 (March 2019 release)

Motivation

These attributes were introduced to drive the migration towards Crosstool in Starlark, but we ended up not needing them. They are currently unused, but cpu attribute was mandatory. This cleanup gets rid of them.

Migration

Delete these attributes. You can use buildozer to perform the removal:

buildozer 'remove cpu' '//:my_toolchain'
buildozer 'remove compiler' '//:my_toolchain'
@hlopko hlopko self-assigned this Jan 10, 2019
@hlopko hlopko added incompatible-change Incompatible/breaking change Bazel 1.0 P1 I'll work on this now. (Assignee required) P2 We'll consider working on this in future. (Assignee optional) team-Rules-CPP Issues for C++ rules and removed P1 I'll work on this now. (Assignee required) labels Jan 10, 2019
bazel-io pushed a commit that referenced this issue Jan 10, 2019
@hlopko
Add --incompatible_remove_cpu_and_compiler_attributes_from_cc_toolchain
9bf885a 
These attributes were introduced to drive the migration towards Crosstool in Starlark, but we ended up not needing them. They are currently unused, but cpu attribute is mandatory. This cleanup gets rid of them.

#7075

RELNOTES: None.
PiperOrigin-RevId: 228723472
@laurentlb
Copy link
Contributor

laurentlb commented Feb 26, 2019 •
edited
Loading

It looks like this flag is not available in Bazel 0.23.

Edit. The flag is available, but there was a typo in the title.

@laurentlb laurentlb changed the title incompatible_disable_cpu_and_compiler_attributes_from_cc_toolchain incompatible_remove_cpu_and_compiler_attributes_from_cc_toolchain Feb 26, 2019
@hlopko
Copy link
Member Author

hlopko commented Feb 26, 2019

Sorry for that, and thanks for fixing!

@katre
Copy link
Member

katre commented Mar 1, 2019

This issue was tagged as "breaking-change-0.24" but does not appear ready to be flipped in the 0.24.0 release. If this is incorrect please comment on that issue and discuss with me.

@hlopko
Copy link
Member Author

hlopko commented Mar 4, 2019

Yup this is correct, I missed the flip window between 0.23 release and 0.24 cut :)

bazel-io pushed a commit that referenced this issue Mar 21, 2019
@hlopko
Generate cc_toolchain_cc.bzl instead of CROSSTOOL for android ndks
7e39391 
Before this cl, AndroidNdkRepositoryFunction generated CROSSTOOL file that configured the C++ toolchain for ndk. This cl changes this function to generate a Starlark rule providing CcToolchainConfigInfo, which is the "new" way of configuring C++ toolchains. This change should not be observable by ndk users.

As a result, generated ndk toolchain is forward compatible with incompatible changes:
* #7008
* #6861
* #7320
* #7075

RELNOTES: Android NDK C++ toolchain is now configured in Starlark. This should be a backwards compatible change, but in case of bugs blame unknown commit.
PiperOrigin-RevId: 239565213
bazel-io pushed a commit that referenced this issue May 1, 2019
@dkelmer
Release 0.25.0 (2019-05-01)
2ab3866 
Baseline: 0366246

Cherry picks:

   + 3f7f255:
     Windows: fix native test wrapper's arg. escaping
   + afeb8d0:
     Flip --incompatible_windows_escape_jvm_flags
   + 4299b65:
     Sort DirectoryNode children to ensure validity.
   + 231270c:
     Conditionally use deprecated signature for initWithContentsOfURL
   + 75a3a53:
     Add http_archive entries for testing with various JDK versions.
   + 4a6354a:
     Now that ubuntu1804 uses JDK 11, remove explicit
     ubuntu1804_java11 tests.
   + ae102fb:
     Fix wrong name of ubuntu1804_javabase9 task.
   + 0020a97:
     Remove @executable_path/Frameworks from rpaths
   + 130f86d:
     Download stderr/stdout to a temporary FileOutErr

Incompatible changes:

  - (Starlark rules) The legacy "py" provider can no longer be passed
    to or produced by native Python rules; use
    [PyInfo](https://docs.bazel.build/versions/master/skylark/lib/PyIn
    fo.html) instead. See
    [#7298](#7298) for more
    information.
  - (Python rules) The `default_python_version` attribute of the
    `py_binary` and `py_test` rules has been renamed to
    `python_version`. Also, the `--force_python` flag has been
    renamed to `--python_version`. See
    [#7308](#7308) for more
    information.
  - (Python rules) The python version now changes to whatever version
    is specified in a `py_binary` or `py_test`'s `python_version`
    attribute, instead of being forced to the value set by a command
    line flag. You can temporarily revert this change with
    `--incompatible_allow_python_version_transitions=false`. See
    [#7307](#7307) for more
    information.
  - --incompatible_disable_third_party_license_checking` is enabled
    by default
  - Introduced --incompatible_use_python_toolchains, which supersedes
    --python_top/--python_path. See #7899 and #7375 for more
    information.
  - Python 3 is now the default Python version (for `py_binary` and
    `py_test` targets that don't specify the `python_version`
    attribute). Targets that are built for Python 3 will no longer
    have their output put in a separate `-py3` directory; instead
    there is now a separate `-py2` directory for Python 2 targets.
    See #7359 and #7593 for more information.
  - objc_library resource attributes are now disabled by default.
    Please migrate them to data instead. See
    #7594 for more info.
  - Flip --incompatible_windows_escape_jvm_flags to true. See
    #7486

New features:

  - genrules now support a $(RULEDIR) variable that resolves to the
    directory where the outputs of the rule are put.
  - Added --incompatible_windows_native_test_wrapper flag: enables
    using the Bash-less test wrapper on Windows. (No-op on other
    platforms.)

Important changes:

  - incompatible_use_jdk11_as_host_javabase: makes JDK 11 the default
    --host_javabase for remote jdk
    (#7219)
  - Makes genquery somepath output deterministic.
  - Tristate attributes of native rules now reject True/False (use
    1/0)
  - Rollback of "Tristate attributes of native rules now reject
    True/False (use 1/0)"
  - Tristate attributes of native rules now reject True/False (use
    1/0)
  - Added -incompatible_do_not_split_linking_cmdline flag. See #7670
  - Tristate attributes of native rules now temporarily accept
    True/False again
  - `--incompatible_disable_legacy_crosstool_fields` has been flipped
    (#6861)
    `--incompatible_disable_expand_if_all_available_in_flag_set` has
    been flipped (#7008)
  - `--incompatible_disable_legacy_crosstool_fields` has been flipped
    (#6861)
    `--incompatible_disable_expand_if_all_available_in_flag_set...
    RELNOTES: None.
  - --incompatible_no_transitive_loads is enabled by default.
  - Makes TreeArtifact deterministic.
  - --incompatible_no_transitive_loads is enabled by default.
  - Android NDK C++ toolchain is now configured in Starlark. This
    should be a backwards compatible change, but in case of bugs
    blame unknown commit.
  - `--incompatible_disable_legacy_crosstool_fields` has been flipped
    (#6861)
    `--incompatible_disable_expand_if_all_available_in_flag_set` has
    been flipped (#7008)
  - --incompatible_no_transitive_loads is enabled by default.
  - --incompatible_bzl_disallow_load_after_statement is enabled
  - Added `--incompatible_require_ctx_in_configure_features`, see
    #7793 for details.
  - Flag --incompatible_merge_genfiles_directory is flipped. This
    removes the directory `bazel-genfiles` in favor of `bazel-bin`.
  - previously deprecated flag --experimental_remote_spawn_cache was
    removed
  - `--incompatible_disallow_load_labels_to_cross_package_boundaries`
    is enabled by default
  - Fix an issue where the Android resource processor did not surface
    errors from aapt2 compile and link actions.
  - --incompatible_no_attr_license is enabled by default
  - `--incompatible_disable_crosstool_file` has been flipped
    (#7320)
  - A new flag `--incompatible_string_join_requires_strings` is
    introduced. The sequence argument of `string.join` must contain
    only string elements.
  - --incompatible_symlinked_sandbox_expands_tree_artifacts_in_runfile
    s_tree has been flipped
  - Incompatible flag `--incompatible_disable_legacy_cc_provider` has
    been flipped (see #7036
    for details).
  - Don't drop the analysis cache when the same --define flag is set
    multiple times and the last value is the same (e.g. if the
    current invocation was run with "--define foo=bar" and the
    previous one was run with "--define foo=baz --define foo=bar").
  - The --incompatible_disable_genrule_cc_toolchain_dependency flag
    has been flipped (see
    #6867 for details).
  - Incompatible change
    `--incompatible_remove_cpu_and_compiler_attributes_from_cc_toolcha
    in` has been flipped (see
    #7075 for details).
  - --noexperimental_java_coverage is a no-op flag.
  - --experimental_java_coverage/--incompatible_java_coverage flag was
    removed. See #7425.
  - incompatible_use_toolchain_providers_in_java_common: pass
    JavaToolchainInfo and JavaRuntimeInfo providers to java_common
    APIs instead of configured targets
    (#7186.)
  - --incompatible_remote_symlinks has been flipped. The remote
    caching and execution protocol will now represent symlinks in
    outputs as such. See
    #7917 for more details.
  - Bazel is now ~20MiB smaller, from unbundling the Android rules'
    runtime dependencies.

This release contains contributions from many people at Google, as well as Andreas Herrmann, Andrew Suffield, Andy Scott, Benjamin Peterson, Ed Baunton, George Gensure, Ian McGinnis, Ity Kaul, Jingwen Chen, John Millikin, Keith Smiley, Marwan Tammam, Mike Fourie, Oscar Bonilla, perwestling, petros, Robert Sayre, Ryan Beasley, silvergasp, Stanimir Mladenov, Travis Cline, Vladimir Chebotarev, ??.
@Kernald Kernald mentioned this issue May 2, 2019
Closed
dkelmer pushed a commit that referenced this issue May 6, 2019
@dkelmer
Release 0.25.0 (2019-05-01)
f44bc47 
Baseline: 0366246

Cherry picks:

   + 3f7f255:
     Windows: fix native test wrapper's arg. escaping
   + afeb8d0:
     Flip --incompatible_windows_escape_jvm_flags
   + 4299b65:
     Sort DirectoryNode children to ensure validity.
   + 231270c:
     Conditionally use deprecated signature for initWithContentsOfURL
   + 75a3a53:
     Add http_archive entries for testing with various JDK versions.
   + 4a6354a:
     Now that ubuntu1804 uses JDK 11, remove explicit
     ubuntu1804_java11 tests.
   + ae102fb:
     Fix wrong name of ubuntu1804_javabase9 task.
   + 0020a97:
     Remove @executable_path/Frameworks from rpaths
   + 130f86d:
     Download stderr/stdout to a temporary FileOutErr

Incompatible changes:

  - (Starlark rules) The legacy "py" provider can no longer be passed
    to or produced by native Python rules; use
    [PyInfo](https://docs.bazel.build/versions/master/skylark/lib/PyIn
    fo.html) instead. See
    [#7298](#7298) for more
    information.
  - (Python rules) The `default_python_version` attribute of the
    `py_binary` and `py_test` rules has been renamed to
    `python_version`. Also, the `--force_python` flag has been
    renamed to `--python_version`. See
    [#7308](#7308) for more
    information.
  - (Python rules) The python version now changes to whatever version
    is specified in a `py_binary` or `py_test`'s `python_version`
    attribute, instead of being forced to the value set by a command
    line flag. You can temporarily revert this change with
    `--incompatible_allow_python_version_transitions=false`. See
    [#7307](#7307) for more
    information.
  - --incompatible_disable_third_party_license_checking` is enabled
    by default
  - Introduced --incompatible_use_python_toolchains, which supersedes
    --python_top/--python_path. See #7899 and #7375 for more
    information.
  - Python 3 is now the default Python version (for `py_binary` and
    `py_test` targets that don't specify the `python_version`
    attribute). Targets that are built for Python 3 will no longer
    have their output put in a separate `-py3` directory; instead
    there is now a separate `-py2` directory for Python 2 targets.
    See #7359 and #7593 for more information.
  - objc_library resource attributes are now disabled by default.
    Please migrate them to data instead. See
    #7594 for more info.
  - Flip --incompatible_windows_escape_jvm_flags to true. See
    #7486

New features:

  - genrules now support a $(RULEDIR) variable that resolves to the
    directory where the outputs of the rule are put.
  - Added --incompatible_windows_native_test_wrapper flag: enables
    using the Bash-less test wrapper on Windows. (No-op on other
    platforms.)

Important changes:

  - incompatible_use_jdk11_as_host_javabase: makes JDK 11 the default
    --host_javabase for remote jdk
    (#7219)
  - Makes genquery somepath output deterministic.
  - Tristate attributes of native rules now reject True/False (use
    1/0)
  - Rollback of "Tristate attributes of native rules now reject
    True/False (use 1/0)"
  - Tristate attributes of native rules now reject True/False (use
    1/0)
  - Added -incompatible_do_not_split_linking_cmdline flag. See #7670
  - Tristate attributes of native rules now temporarily accept
    True/False again
  - `--incompatible_disable_legacy_crosstool_fields` has been flipped
    (#6861)
    `--incompatible_disable_expand_if_all_available_in_flag_set` has
    been flipped (#7008)
  - `--incompatible_disable_legacy_crosstool_fields` has been flipped
    (#6861)
    `--incompatible_disable_expand_if_all_available_in_flag_set...
    RELNOTES: None.
  - --incompatible_no_transitive_loads is enabled by default.
  - Makes TreeArtifact deterministic.
  - --incompatible_no_transitive_loads is enabled by default.
  - Android NDK C++ toolchain is now configured in Starlark. This
    should be a backwards compatible change, but in case of bugs
    blame unknown commit.
  - `--incompatible_disable_legacy_crosstool_fields` has been flipped
    (#6861)
    `--incompatible_disable_expand_if_all_available_in_flag_set` has
    been flipped (#7008)
  - --incompatible_no_transitive_loads is enabled by default.
  - --incompatible_bzl_disallow_load_after_statement is enabled
  - Added `--incompatible_require_ctx_in_configure_features`, see
    #7793 for details.
  - Flag --incompatible_merge_genfiles_directory is flipped. This
    removes the directory `bazel-genfiles` in favor of `bazel-bin`.
  - previously deprecated flag --experimental_remote_spawn_cache was
    removed
  - `--incompatible_disallow_load_labels_to_cross_package_boundaries`
    is enabled by default
  - Fix an issue where the Android resource processor did not surface
    errors from aapt2 compile and link actions.
  - --incompatible_no_attr_license is enabled by default
  - `--incompatible_disable_crosstool_file` has been flipped
    (#7320)
  - A new flag `--incompatible_string_join_requires_strings` is
    introduced. The sequence argument of `string.join` must contain
    only string elements.
  - --incompatible_symlinked_sandbox_expands_tree_artifacts_in_runfile
    s_tree has been flipped
  - Incompatible flag `--incompatible_disable_legacy_cc_provider` has
    been flipped (see #7036
    for details).
  - Don't drop the analysis cache when the same --define flag is set
    multiple times and the last value is the same (e.g. if the
    current invocation was run with "--define foo=bar" and the
    previous one was run with "--define foo=baz --define foo=bar").
  - The --incompatible_disable_genrule_cc_toolchain_dependency flag
    has been flipped (see
    #6867 for details).
  - Incompatible change
    `--incompatible_remove_cpu_and_compiler_attributes_from_cc_toolcha
    in` has been flipped (see
    #7075 for details).
  - --noexperimental_java_coverage is a no-op flag.
  - --experimental_java_coverage/--incompatible_java_coverage flag was
    removed. See #7425.
  - incompatible_use_toolchain_providers_in_java_common: pass
    JavaToolchainInfo and JavaRuntimeInfo providers to java_common
    APIs instead of configured targets
    (#7186.)
  - --incompatible_remote_symlinks has been flipped. The remote
    caching and execution protocol will now represent symlinks in
    outputs as such. See
    #7917 for more details.
  - Bazel is now ~20MiB smaller, from unbundling the Android rules'
    runtime dependencies.

This release contains contributions from many people at Google, as well as Andreas Herrmann, Andrew Suffield, Andy Scott, Benjamin Peterson, Ed Baunton, George Gensure, Ian McGinnis, Ity Kaul, Jingwen Chen, John Millikin, Keith Smiley, Marwan Tammam, Mike Fourie, Oscar Bonilla, perwestling, petros, Robert Sayre, Ryan Beasley, silvergasp, Stanimir Mladenov, Travis Cline, Vladimir Chebotarev, ??.
@luorixiangyang
Copy link

luorixiangyang commented May 7, 2019 •
edited
Loading

I do the command in windows10:
bazel build --config=opt --config=cuda --define=no_tensorflow_py_deps=true --incompatible_remove_cpu_and_compiler_attributes_from_cc_toolchain //tensorflow/tools/pip_package:build_pip_package

Occur the exception:
in cc_toolchain rule @local_config_cuda//crosstool:cc-compiler-local: attributes 'cpu' and 'compiler' have been deprecated, please remove them. See #7075 for details.

how to fix it?

bazel-io pushed a commit that referenced this issue May 7, 2019
@scentini
Remove unsupported cpu attribute from cc_toolchains.
81aefe7 
Fixes #8236

Issue #7075

RELNOTES: None.
PiperOrigin-RevId: 247014090
dkelmer pushed a commit that referenced this issue May 7, 2019
@scentini @dkelmer
Remove unsupported cpu attribute from cc_toolchains.
88cdc94 
Fixes #8236

Issue #7075

RELNOTES: None.
PiperOrigin-RevId: 247014090
@scentini
Copy link
Contributor

scentini commented May 7, 2019

@luorixiangyang you're seeing this error message because you're using Bazel 25.x and Tensorflow doesn't yet support that version. It's a work in progress though, should be fixed very soon.

aehlig pushed a commit that referenced this issue May 8, 2019
@scentini @aehlig
Remove unsupported cpu attribute from cc_toolchains.
54e7c83 
Fixes #8236

Issue #7075

RELNOTES: None.
PiperOrigin-RevId: 247014090
@luorixiangyang luorixiangyang mentioned this issue May 8, 2019
Closed
aehlig pushed a commit that referenced this issue May 9, 2019
@scentini @aehlig
Remove unsupported cpu attribute from cc_toolchains.
af18795 
Fixes #8236

Issue #7075

RELNOTES: None.
PiperOrigin-RevId: 247014090
aehlig pushed a commit that referenced this issue May 10, 2019
@scentini @aehlig
Remove unsupported cpu attribute from cc_toolchains.
ea2cbab 
Fixes #8236

Issue #7075

RELNOTES: None.
PiperOrigin-RevId: 247014090
aehlig pushed a commit that referenced this issue May 10, 2019
@scentini @aehlig
Remove unsupported cpu attribute from cc_toolchains.
d890a9f 
Fixes #8236

Issue #7075

RELNOTES: None.
PiperOrigin-RevId: 247014090
@luorixiangyang luorixiangyang mentioned this issue May 11, 2019
Closed
aehlig pushed a commit that referenced this issue May 13, 2019
@scentini @aehlig
Remove unsupported cpu attribute from cc_toolchains.
906c4b8 
Fixes #8236

Issue #7075

RELNOTES: None.
PiperOrigin-RevId: 247014090
aehlig pushed a commit that referenced this issue May 17, 2019
@scentini @aehlig
Remove unsupported cpu attribute from cc_toolchains.
4b328c9 
Fixes #8236

Issue #7075

RELNOTES: None.
PiperOrigin-RevId: 247014090
aehlig pushed a commit that referenced this issue May 17, 2019
@scentini @aehlig
Remove unsupported cpu attribute from cc_toolchains.
d49d4f0 
Fixes #8236

Issue #7075

RELNOTES: None.
PiperOrigin-RevId: 247014090
aehlig pushed a commit that referenced this issue May 20, 2019
@scentini @aehlig
Remove unsupported cpu attribute from cc_toolchains.
e4f9ba8 
Fixes #8236

Issue #7075

RELNOTES: None.
PiperOrigin-RevId: 247014090
aehlig pushed a commit that referenced this issue May 21, 2019
@scentini @aehlig
Remove unsupported cpu attribute from cc_toolchains.
189b8e5 
Fixes #8236

Issue #7075

RELNOTES: None.
PiperOrigin-RevId: 247014090
aehlig pushed a commit that referenced this issue May 22, 2019
@scentini @aehlig
Remove unsupported cpu attribute from cc_toolchains.
22235e8 
Fixes #8236

Issue #7075

RELNOTES: None.
PiperOrigin-RevId: 247014090
aehlig pushed a commit that referenced this issue May 23, 2019
@scentini @aehlig
Remove unsupported cpu attribute from cc_toolchains.
471143a 
Fixes #8236

Issue #7075

RELNOTES: None.
PiperOrigin-RevId: 247014090
aehlig pushed a commit that referenced this issue May 23, 2019
@scentini @aehlig
Remove unsupported cpu attribute from cc_toolchains.
69e9f5d 
Fixes #8236

Issue #7075

RELNOTES: None.
PiperOrigin-RevId: 247014090
aehlig pushed a commit that referenced this issue May 24, 2019
@scentini @aehlig
Remove unsupported cpu attribute from cc_toolchains.
0d35f88 
Fixes #8236

Issue #7075

RELNOTES: None.
PiperOrigin-RevId: 247014090
alexanderilyin added a commit to alexanderilyin/bazel that referenced this issue Jul 9, 2019
@alexanderilyin
Update cc-toolchain-config.md
2d71dfb 
ERROR: .../examples/cpp-tutorial/stage1/toolchain/BUILD:11:1: in cc_toolchain rule //toolchain:asmjs_toolchain: attributes 'cpu' and 'compiler' have been deprecated, please remove them. See bazelbuild#7075 for details.
@ahyangyi ahyangyi mentioned this issue Sep 10, 2019
Open
@yicm yicm mentioned this issue Aug 5, 2020
Open
@bbulkow bbulkow mentioned this issue Aug 25, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hlopko hlopko

Labels
incompatible-change Incompatible/breaking change P2 We'll consider working on this in future. (Assignee optional) team-Rules-CPP Issues for C++ rules
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@katre @laurentlb @hlopko @meteorcloudy @dslomov @luorixiangyang @scentini and others