Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incompatible_remove_cpu_and_compiler_attributes_from_cc_toolchain #7075

Closed
hlopko opened this Issue Jan 10, 2019 · 4 comments

Comments

Projects
None yet
5 participants
@hlopko
Copy link
Contributor

commented Jan 10, 2019

Flag: --incompatible_remove_cpu_and_compiler_attributes_from_cc_toolchain
Available since: 0.23 (February 2019 release)
Will be flipped in: 0.24 (March 2019 release)

Motivation

These attributes were introduced to drive the migration towards Crosstool in Starlark, but we ended up not needing them. They are currently unused, but cpu attribute was mandatory. This cleanup gets rid of them.

Migration

Delete these attributes. You can use buildozer to perform the removal:

buildozer 'remove cpu' '//:my_toolchain'
buildozer 'remove compiler' '//:my_toolchain'

@hlopko hlopko self-assigned this Jan 10, 2019

bazel-io pushed a commit that referenced this issue Jan 10, 2019

Add --incompatible_remove_cpu_and_compiler_attributes_from_cc_toolchain
These attributes were introduced to drive the migration towards Crosstool in Starlark, but we ended up not needing them. They are currently unused, but cpu attribute is mandatory. This cleanup gets rid of them.

#7075

RELNOTES: None.
PiperOrigin-RevId: 228723472
@laurentlb

This comment has been minimized.

Copy link
Contributor

commented Feb 26, 2019

It looks like this flag is not available in Bazel 0.23.

Edit. The flag is available, but there was a typo in the title.

@laurentlb laurentlb changed the title incompatible_disable_cpu_and_compiler_attributes_from_cc_toolchain incompatible_remove_cpu_and_compiler_attributes_from_cc_toolchain Feb 26, 2019

@hlopko

This comment has been minimized.

Copy link
Contributor Author

commented Feb 26, 2019

Sorry for that, and thanks for fixing!

@katre

This comment has been minimized.

Copy link
Member

commented Mar 1, 2019

This issue was tagged as "breaking-change-0.24" but does not appear ready to be flipped in the 0.24.0 release. If this is incorrect please comment on that issue and discuss with me.

@hlopko

This comment has been minimized.

Copy link
Contributor Author

commented Mar 4, 2019

Yup this is correct, I missed the flip window between 0.23 release and 0.24 cut :)

bazel-io pushed a commit that referenced this issue Mar 21, 2019

Generate cc_toolchain_cc.bzl instead of CROSSTOOL for android ndks
Before this cl, AndroidNdkRepositoryFunction generated CROSSTOOL file that configured the C++ toolchain for ndk. This cl changes this function to generate a Starlark rule providing CcToolchainConfigInfo, which is the "new" way of configuring C++ toolchains. This change should not be observable by ndk users.

As a result, generated ndk toolchain is forward compatible with incompatible changes:
* #7008
* #6861
* #7320
* #7075

RELNOTES: Android NDK C++ toolchain is now configured in Starlark. This should be a backwards compatible change, but in case of bugs blame unknown commit.
PiperOrigin-RevId: 239565213

irengrig added a commit to irengrig/bazel that referenced this issue Mar 25, 2019

Generate cc_toolchain_cc.bzl instead of CROSSTOOL for android ndks
Before this cl, AndroidNdkRepositoryFunction generated CROSSTOOL file that configured the C++ toolchain for ndk. This cl changes this function to generate a Starlark rule providing CcToolchainConfigInfo, which is the "new" way of configuring C++ toolchains. This change should not be observable by ndk users.

As a result, generated ndk toolchain is forward compatible with incompatible changes:
* bazelbuild#7008
* bazelbuild#6861
* bazelbuild#7320
* bazelbuild#7075

RELNOTES: Android NDK C++ toolchain is now configured in Starlark. This should be a backwards compatible change, but in case of bugs blame unknown commit.
PiperOrigin-RevId: 239565213

@bazel-io bazel-io closed this in b376726 Mar 29, 2019

emusand added a commit to emusand/bazel that referenced this issue Apr 16, 2019

Generate cc_toolchain_cc.bzl instead of CROSSTOOL for android ndks
Before this cl, AndroidNdkRepositoryFunction generated CROSSTOOL file that configured the C++ toolchain for ndk. This cl changes this function to generate a Starlark rule providing CcToolchainConfigInfo, which is the "new" way of configuring C++ toolchains. This change should not be observable by ndk users.

As a result, generated ndk toolchain is forward compatible with incompatible changes:
* bazelbuild#7008
* bazelbuild#6861
* bazelbuild#7320
* bazelbuild#7075

RELNOTES: Android NDK C++ toolchain is now configured in Starlark. This should be a backwards compatible change, but in case of bugs blame unknown commit.
PiperOrigin-RevId: 239565213

emusand added a commit to emusand/bazel that referenced this issue Apr 16, 2019

Flip --incompatible_remove_cpu_and_compiler_attributes_from_cc_toolchain
Fixes bazelbuild#7075.

RELNOTES: Incompatible change `--incompatible_remove_cpu_and_compiler_attributes_from_cc_toolchain` has been flipped (see bazelbuild#7075 for details).
PiperOrigin-RevId: 241059021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.