Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bazel0.26.0: genrule outputs files in both gendir and bindir irrespective of the value of output_to_bindir #8698

Closed
abhishek-carbon3d opened this issue Jun 22, 2019 · 3 comments

Comments

@abhishek-carbon3d
Copy link

ATTENTION! Please read and follow:

Description of the problem / feature request:

genrule outputs files in both gendir and bindir irrespective of the value of output_to_bindir

Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

genrule(
name = "test",
srcs = [
],
output_to_bindir = False,
outs = ["test.txt"],
cmd = "echo hello > $@",
)

test.txt is in both bindir and gendir

What operating system are you running Bazel on?

ubuntu18

What's the output of bazel info release?

release 0.26.0

BTW it works as expected in release 0.22.0 so not sure when it was broken

Have you found anything relevant by searching the web?

No

Any other information, logs, or outputs that you want to share?

No

@benjaminp
Copy link
Collaborator

#6761

@laurentlb
Copy link
Contributor

This is working as intended: we're removing the distinction between bazel-bin and bazel-genfiles. Is it breaking your code in any way? Can you avoid using output_to_bindir?

We plan to remove the genfiles directory: #8651

@abhishek-carbon3d
Copy link
Author

It was breaking some home grown rules for nodejs/ts (hoping to switch over to the rapidly evolving official nodejs toolchain soon :).

We have fixed our rules, but I thought I would report this in case it was not intentional. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants