-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RBE / docker sandbox cannot find protobuf dependencies #9032
Comments
Also seeing this issue in https://gitlab.com/remote-apis-testing/remote-apis-testing/ using alternative RE-API server implementations. Similar failures can be seen with buildbarn and buildfarm. Bazel is installed via apt as follows:
|
@lberki steps to reproduce:
diff --git a/bazel/toolchains/rbe_toolchains_config.bzl b/bazel/toolchains/rbe_toolchains_config.bzl
index fd7210db1..490a536f4 100644
--- a/bazel/toolchains/rbe_toolchains_config.bzl
+++ b/bazel/toolchains/rbe_toolchains_config.bzl
@@ -64,7 +64,7 @@ def _envoy_rbe_toolchain(name, env, toolchain_config_spec_name):
repository = _ENVOY_BUILD_IMAGE_REPOSITORY,
toolchain_config_spec_name = toolchain_config_spec_name,
toolchain_config_suite_spec = _TOOLCHAIN_CONFIG_SUITE_SPEC,
- use_checked_in_confs = "Force",
+ use_checked_in_confs = "False",
)
def rbe_toolchains_config():
|
I don't think I'll be able to do anything about this today, but I at least managed to reproduce it. Kinda weird, because I remember fixing the exact same breakage in Envoy when I submitted the culprit change. |
@lberki do you consider this a release blocker for 0.29.0? |
yes (at least until I figure out why this happens) |
Faster reproduction:
|
Welp. It appears that the https://github.com/grpc/grpc/blob/master/bazel/generate_cc.bzl#L114 produces the wrong list of
but 0.29 puts e.g.
|
The good news is that I have a patch:
The bad news this is for gRPC, so I'll have to figure out how to up-integrate it into Envoy. Or else leave it to Someone Else™. |
Update: patch to gRPC sent out: |
Filed bug on Envoy: There is also a pull request to gRPC, so I consider my work done here. |
Description of the problem / feature request:
Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.
bazel build --config=docker-clang //source/exe:envoy-static
from latest master ofhttps://github.com/envoyproxy/envoy
.with bazelisk
last_green
orlast_downstream_green
.This worked well in 0.28.0 / 0.28.1 but not latest master when I was trying out #8934. Without RBE / docker sandbox it works fine too.
What operating system are you running Bazel on?
Ubuntu 16.04
What's the output of
bazel info release
?development vresion
If
bazel info release
returns "development version" or "(@non-git)", tell us how you built Bazel.bazelisk with
latest_green
What's the output of
git remote get-url origin ; git rev-parse master ; git rev-parse HEAD
?https://github.com/lizan/envoy.git
c586af9d3f5940acc73d6a5fd0fdc2c521b6243d
c586af9d3f5940acc73d6a5fd0fdc2c521b6243d
Have you found anything relevant by searching the web?
No
Any other information, logs, or outputs that you want to share?
The text was updated successfully, but these errors were encountered: