Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Xcode 14.3 compatibility #18460

Closed

Conversation

keith
Copy link
Member

@keith keith commented May 19, 2023

With Xcode 14.3+ on x86_64 machines there is an opaque error when linking binaries on macOS because Apple removed an old support library. That library is only linked if the macOS target is < 10.11, so this bumps the default versions past that. This macOS version was released in September 2015.

Fixes #18278

With Xcode 14.3+ on x86_64 machines there is an opaque error when
linking binaries on macOS because Apple removed an old support library.
That library is only linked if the macOS target is < 10.11, so this
bumps the default versions past that. This macOS version was released in
September 2015.

Fixes bazelbuild#18278
@keith keith requested a review from lberki as a code owner May 19, 2023 18:32
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label May 19, 2023
@sgowroji sgowroji added the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label May 22, 2023
@meteorcloudy
Copy link
Member

@bazel-io fork 6.3.0

@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels May 22, 2023
@meteorcloudy
Copy link
Member

@keith Just curious, can you elaborate on what is the difference between this change and #17451?

@keith
Copy link
Member Author

keith commented May 23, 2023

I don't recall specifically which error that was targeted at. But the description of that is correct that technically Xcode 14+ only supports macOS 10.13+ I just chose to be as conservative as possible here since this fixes the only error we know about now

@Pavank1992 Pavank1992 removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label May 24, 2023
iancha1992 pushed a commit to iancha1992/bazel that referenced this pull request May 24, 2023
With Xcode 14.3+ on x86_64 machines there is an opaque error when linking binaries on macOS because Apple removed an old support library. That library is only linked if the macOS target is < 10.11, so this bumps the default versions past that. This macOS version was released in September 2015.

Fixes bazelbuild#18278

Closes bazelbuild#18460.

PiperOrigin-RevId: 534743568
Change-Id: I131880096c941df0097fe3b1faabd5a6afada4f3
iancha1992 added a commit that referenced this pull request May 25, 2023
With Xcode 14.3+ on x86_64 machines there is an opaque error when linking binaries on macOS because Apple removed an old support library. That library is only linked if the macOS target is < 10.11, so this bumps the default versions past that. This macOS version was released in September 2015.

Fixes #18278

Closes #18460.

PiperOrigin-RevId: 534743568
Change-Id: I131880096c941df0097fe3b1faabd5a6afada4f3

Co-authored-by: Keith Smiley <keithbsmiley@gmail.com>
fweikert pushed a commit to fweikert/bazel that referenced this pull request May 25, 2023
With Xcode 14.3+ on x86_64 machines there is an opaque error when linking binaries on macOS because Apple removed an old support library. That library is only linked if the macOS target is < 10.11, so this bumps the default versions past that. This macOS version was released in September 2015.

Fixes bazelbuild#18278

Closes bazelbuild#18460.

PiperOrigin-RevId: 534743568
Change-Id: I131880096c941df0097fe3b1faabd5a6afada4f3
@keith keith deleted the ks/fix-xcode-14.3-compatibility branch June 13, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problems building release-6.1.1 on osx 13.3.1 (22E261) / Xcode 14.3 (14E222b)
4 participants