Bump minimum supported macOS versions to 10.13 #17451
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentleyjones
approved these changes
Feb 9, 2023
sgowroji
added
team-Rules-ObjC
|
just to verify this doesn't produce any new build warnings for deprecated APIs or anything right? also note that these binaries even with this will likely still run on older versions, they just might crash depending on macOS changes, so these values don't matter that much |
Yes, I've built all of the files built with the affected codepaths and there were no warnings (or errors). |
As per https://developer.apple.com/support/xcode/ Xcode from 14.0 no longer supports targeting 10.9, and attempting to do so may fail in obscure ways. 10.13 is still 5+ years old, so we retain coverage for a reasonable range on macOS versions.
illicitonion
force-pushed
the
min-macos-version
branch
from
7ea69e2
to
5238849
Compare
keith
approved these changes
Feb 13, 2023
keith
added a commit
to bazelbuild/apple_support
that referenced
this pull request
Feb 13, 2023
keith
added a commit
to bazelbuild/apple_support
that referenced
this pull request
Feb 13, 2023
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
|
@bazel-io fork 6.1.0 |
bazel-io
removed
the
potential release blocker
meteorcloudy
pushed a commit
that referenced
this pull request
Feb 24, 2023
As per https://developer.apple.com/support/xcode/ Xcode from 14.0 no longer supports targeting 10.9, and attempting to do so may fail in obscure ways. 10.13 is still 5+ years old, so we retain coverage for a reasonable range on macOS versions. Closes #17451. PiperOrigin-RevId: 511577111 Change-Id: I770ff101f52d16f2fc402f054579740b650986cc Co-authored-by: Daniel Wagner-Hall <dwagnerhall@apple.com>
ShreeM01
pushed a commit
to ShreeM01/bazel
that referenced
this pull request
Apr 4, 2023
As per https://developer.apple.com/support/xcode/ Xcode from 14.0 no longer supports targeting 10.9, and attempting to do so may fail in obscure ways. 10.13 is still 5+ years old, so we retain coverage for a reasonable range on macOS versions. Closes bazelbuild#17451. PiperOrigin-RevId: 511577111 Change-Id: I770ff101f52d16f2fc402f054579740b650986cc
keertk
pushed a commit
that referenced
this pull request
Apr 5, 2023
* Bump minimum supported macOS versions to 10.13 As per https://developer.apple.com/support/xcode/ Xcode from 14.0 no longer supports targeting 10.9, and attempting to do so may fail in obscure ways. 10.13 is still 5+ years old, so we retain coverage for a reasonable range on macOS versions. Closes #17451. PiperOrigin-RevId: 511577111 Change-Id: I770ff101f52d16f2fc402f054579740b650986cc * Update BUILD.bazel * Revert change --------- Co-authored-by: Daniel Wagner-Hall <dwagnerhall@apple.com>
|
@bazel-io fork 4.2.4 |
ShreeM01
pushed a commit
to ShreeM01/bazel
that referenced
this pull request
Apr 11, 2023
As per https://developer.apple.com/support/xcode/ Xcode from 14.0 no longer supports targeting 10.9, and attempting to do so may fail in obscure ways. 10.13 is still 5+ years old, so we retain coverage for a reasonable range on macOS versions. Closes bazelbuild#17451. PiperOrigin-RevId: 511577111 Change-Id: I770ff101f52d16f2fc402f054579740b650986cc
ShreeM01
pushed a commit
to ShreeM01/bazel
that referenced
this pull request
Apr 11, 2023
As per https://developer.apple.com/support/xcode/ Xcode from 14.0 no longer supports targeting 10.9, and attempting to do so may fail in obscure ways. 10.13 is still 5+ years old, so we retain coverage for a reasonable range on macOS versions. Closes bazelbuild#17451. PiperOrigin-RevId: 511577111 Change-Id: I770ff101f52d16f2fc402f054579740b650986cc
keertk
added a commit
that referenced
this pull request
Apr 12, 2023
* Bump minimum supported macOS versions to 10.13 As per https://developer.apple.com/support/xcode/ Xcode from 14.0 no longer supports targeting 10.9, and attempting to do so may fail in obscure ways. 10.13 is still 5+ years old, so we retain coverage for a reasonable range on macOS versions. Closes #17451. PiperOrigin-RevId: 511577111 Change-Id: I770ff101f52d16f2fc402f054579740b650986cc --------- Co-authored-by: Daniel Wagner-Hall <dwagnerhall@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per https://developer.apple.com/support/xcode/ Xcode from 14.0 no longer supports targeting 10.9, and attempting to do so may fail in obscure ways.
10.13 is still 5+ years old, so we retain coverage for a reasonable range on macOS versions.