Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation warning in ImportedDynamicFrameworkProcessor: Nesting argument groups is deprecated #2310

Closed
luispadron opened this issue Oct 25, 2023 · 0 comments · Fixed by #2334
Closed

Deprecation warning in ImportedDynamicFrameworkProcessor: Nesting argument groups is deprecated #2310

luispadron opened this issue Oct 25, 2023 · 0 comments · Fixed by #2334
Labels
type: cleanup Code health or technical debt reduction

Comments

@luispadron
Copy link
Contributor

When building with rules_apple 3.1.1 and bzlmod I see the following logs for all our framework targets during a build:

INFO: From ImportedDynamicFrameworkProcessor Code/Features/Inflows/CheckDeposit/CheckDeposit-DevApp-intermediates/_imported_frameworks/MobileFlow.framework.zip:
/private/var/tmp/_bazel_lpadron/9ae9416857eb79bb978de35a53d54970/execroot/_main/bazel-out/darwin_arm64-opt-exec-2B5CBBC6-ST-a1f9b58d10ba/bin/external/rules_apple~3.1.1/tools/imported_dynamic_framework_processor/imported_dynamic_framework_processor.runfiles/rules_apple~3.1.1/tools/imported_dynamic_framework_processor/imported_dynamic_framework_processor.py:291: DeprecationWarning: Nesting argument groups is deprecated.
  codesigningtool_args = mutex_group.add_argument_group()
@luispadron luispadron added the type: cleanup Code health or technical debt reduction label Nov 25, 2023
@jszumski jszumski mentioned this issue Nov 29, 2023
Merged
luispadron pushed a commit that referenced this issue Jan 3, 2024
@jszumski
Fix deprecation warning in imported_dynamic_framework_processor.py (#…
7f6a44c 
…2334)

Fixes #2310 by removing the mutually exclusive code signing arg group in
`imported_dynamic_framework_processor.py`.

Per python/cpython#30098 the nested
configuration was never intended to work anyway.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: cleanup Code health or technical debt reduction
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix deprecation warning in imported_dynamic_framework_processor.py jszumski/rules_apple
1 participant
@luispadron