Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-22047: [argparse] deprecate nested argument groups and mutually e… #30098

Merged
merged 2 commits into from
Dec 16, 2021

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Dec 14, 2021

Copy link
Contributor

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @iritkatriel.

@MiguelX413
Copy link

What was the rationale behind this?

@iritkatriel
Copy link
Member Author

What was the rationale behind this?

The background is in the issue.

https://bugs.python.org/issue22047

alpernebbi added a commit to alpernebbi/depthcharge-tools that referenced this pull request Sep 26, 2022
This makes Groups able to somewhat properly wrap Arguments and other
Groups, so that we can add @Group.add on top of an @argument() chain
which already creates an implicit group for a single method.

Nesting groups is slightly problematic because argparse doesn't really
support them [1]. Most important issue for us is that the inner groups
don't show up in the help message, but that is easily solved by
flattening the arguments into the outermost group.

[1] python/cpython#30098

Signed-off-by: Alper Nebi Yasak <alpernebiyasak@gmail.com>
luispadron pushed a commit to bazelbuild/rules_apple that referenced this pull request Jan 3, 2024
…2334)

Fixes #2310 by removing the mutually exclusive code signing arg group in
`imported_dynamic_framework_processor.py`.

Per python/cpython#30098 the nested
configuration was never intended to work anyway.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants