Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating release process to use stable tarball urls #1059

Merged
merged 6 commits into from
Oct 25, 2023

Conversation

jsharpe
Copy link
Member

@jsharpe jsharpe commented Jun 13, 2023

Uses the workflows defined in the bazel-contrib/rules-template repo.

This switches the release process to generate and upload tarball artifacts to github so that the bazel central registry (and use in WORKSPACE) can reference tarballs with stable SHAs even if github decide to make changes in the future.

Slightly annoying that the workflow requires creating a empty .bazelrc file but it is what it is.

\`\`\`starlark
bazel_dep(name = "rules_foreign_cc", version = "${TAG:1}")
\`\`\`

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: need to add example of using the extension to select tool versions here.

Copy link
Collaborator

@UebelAndre UebelAndre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As part of this, can you go though all release versions and make new tags?

)
EOF

# TODO: add example of how to configure for both bzlmod and WORKSPACE
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this TODO simply copied and pasted or did you write it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No; this is a genuine TODO - I need to add an example of how you select the cmake / ninja versions using the bzlmod extension here.

@jsharpe
Copy link
Member Author

jsharpe commented Oct 25, 2023

As part of this, can you go though all release versions and make new tags?

Do you mean to run this action on previous releases? I think the best way to generate stable URLs is simply to download the current artifacts and upload them as artifacts to each release which is a different process to what this step would generate as I suspect the sha will change if we use this script on previous releases.

@jsharpe jsharpe enabled auto-merge (squash) October 25, 2023 16:18
@jsharpe jsharpe merged commit fa1d617 into bazel-contrib:main Oct 25, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants