-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating release process to use stable tarball urls #1059
Conversation
…rib/rules-template
\`\`\`starlark | ||
bazel_dep(name = "rules_foreign_cc", version = "${TAG:1}") | ||
\`\`\` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: need to add example of using the extension to select tool versions here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As part of this, can you go though all release versions and make new tags?
) | ||
EOF | ||
|
||
# TODO: add example of how to configure for both bzlmod and WORKSPACE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this TODO simply copied and pasted or did you write it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No; this is a genuine TODO - I need to add an example of how you select the cmake / ninja versions using the bzlmod extension here.
Do you mean to run this action on previous releases? I think the best way to generate stable URLs is simply to download the current artifacts and upload them as artifacts to each release which is a different process to what this step would generate as I suspect the sha will change if we use this script on previous releases. |
Uses the workflows defined in the bazel-contrib/rules-template repo.
This switches the release process to generate and upload tarball artifacts to github so that the bazel central registry (and use in WORKSPACE) can reference tarballs with stable SHAs even if github decide to make changes in the future.
Slightly annoying that the workflow requires creating a empty
.bazelrc
file but it is what it is.