Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add libsodium to examples #1109

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

xytan0056
Copy link
Contributor

add libsodium to examples

@xytan0056 xytan0056 marked this pull request as ready for review October 23, 2023 19:26
@jsharpe
Copy link
Collaborator

jsharpe commented Oct 23, 2023

Just a general note that in general we're not expanding the examples to build extra projects that don't exercise some unique configuration of the rules as CI in slow as it is and this would only serve to make it slower. Longer term the correct place to contribute this is to the bazel central registry.

@xytan0056
Copy link
Contributor Author

@jsharpe got it.
We were just trying repro an error in our repository to build libsodium with the same config :

this is what we get from our repository only happening on mac os

libtool: warning: '-version-info/-version-number' is ignored for convenience libraries
ar: only one of -a and -[bi] options allowed
usage:  ar -d [-TLsv] archive file ...
        ar -m [-TLsv] archive file ...
        ar -m [-abiTLsv] position archive file ...
        ar -p [-TLsv] archive [file ...]
        ar -q [-cTLsv] archive file ...
        ar -r [-cuTLsv] archive file ...
        ar -r [-abciuTLsv] position archive file ...
        ar -t [-TLsv] archive [file ...]
        ar -x [-ouTLsv] archive [file ...]

turns out #928 introduced cxx_linker_static to AR_FLAGS that has -static -s, but static is not a viable flag for ar.

Upon further look, it looks like libtool here in examples points to /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool. But ours points to ../../libtool in bazel sandbox.

Do you happen to know how that's configured?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants