Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gomock.bzl: Use github.com/uber-go/mock instead of unmaintained github.com/golang/mock #3709

Open
manjari25 opened this issue Sep 25, 2023 · 2 comments · May be fixed by #3710
Open

gomock.bzl: Use github.com/uber-go/mock instead of unmaintained github.com/golang/mock #3709

manjari25 opened this issue Sep 25, 2023 · 2 comments · May be fixed by #3710

Comments

@manjari25
Copy link

Starting June 2023, github.com/golang/mock is no longer maintained and has been archived. The repo forked from this at github.com/uber-go/mock is actively maintained and provides the same functionality.

rules_go should support a gomock.bzl rule that uses the maintained fork instead of the archived repo.
@manjari25 manjari25 linked a pull request Sep 25, 2023 that will close this issue
Draft
@achew22
Copy link
Member

achew22 commented Sep 25, 2023

The correct move here for us to do would be to remove go mock entirely then. Let's take this opportunity to mark the rule deprecated.

@timofurrer
Copy link

@achew22 can you elaborate on that decision? Why would you remove it entirely instead of just switching over to uber-go/mock ?

And is there any plans to continue with #3710 in case you decide to actually not deprecate it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate github.com/golang/mock to github.com/uber-go/mock manjari25/rules_go
3 participants
@achew22 @timofurrer @manjari25