Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gazelle: extract import path from Go package comments and proto go_package options #874

Closed
jayconrod opened this issue Oct 4, 2017 · 1 comment
Closed

Gazelle: extract import path from Go package comments and proto go_package options #874

jayconrod opened this issue Oct 4, 2017 · 1 comment
Labels
enhancement gazelle

Comments

@jayconrod
Copy link
Contributor

Currently, Gazelle always sets the importpath attribute of a rule based on the prefix and its location within the repository. Gazelle should respect canonical import paths written in package comments.

package foo // import example.com/repo/foo

It should also use import paths from protos.

syntax = "proto3";

option go_package = "example.com/repo/foo";
@jayconrod jayconrod mentioned this issue Dec 26, 2017
Closed
@jayconrod
Copy link
Contributor Author

Migrated to bazel-contrib/bazel-gazelle#53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement gazelle
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jayconrod