Gazelle: fix deletion of rules with deps #1130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 12, 2017 15:57
Rules are deleted after they are merged with empty rules produced by the generator when they have no attributes other than "name" and "visibility". An earlier change split merging into two phases: everything except "deps", and then "deps". With this change, both merge phases have a chance to delete rules. This means that rules that had deps but are now empty will be deleted. Fixes bazel-contrib/bazel-gazelle#22
ianthehat
approved these changes
Dec 12, 2017
|
Jenkins test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rules are deleted after they are merged with empty rules produced by
the generator when they have no attributes other than "name" and
"visibility".
An earlier change split merging into two phases: everything except
"deps", and then "deps".
With this change, both merge phases have a chance to delete
rules. This means that rules that had deps but are now empty will be
deleted.
Fixes bazel-contrib/bazel-gazelle#22