-
-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken bzl_library build graph #2988
Fix broken bzl_library build graph #2988
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
Thanks for the fix! Can you also add a command that would have identified this problem to our CI script, to prevent regression? |
@robfig something would have to evaluate the starlark load statements to detect a missing edge in the graph, and @cvarier and I are working on #2437 which would add such a regression test. The only alternative I can think of is to introduce a usage of gazelle in this repo to generate the bzl_library targets, and then on CI assert that gazelle finds no changes to make. But that seems hard per https://github.com/bazelbuild/rules_go/blob/master/BUILD.bazel#L40-L42 |
OK, thanks! |
What type of PR is this?
What does this PR do? Why is it needed?
Currently,
//go/private:context
is missing a dep on//go/private/rules:transition
, which is necessary in order to load@io_bazel_stardoc//stardoc:stardoc.bzl
. This will be used in a subsequent PR for adding targets to generate Stardoc output.