Add tests for --combined_report=lcov #3344
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes tests for bazel-contrib#3294 See more context: bazel-contrib#3343
fmeum
reviewed
Nov 8, 2022
| }) | ||
|
|
||
| t.Run("with-combined-lcov", func(t *testing.T) { | ||
| testCoverage(t, "set", "bazel-out/_coverage/_coverage_report.dat", "--combined_report=lcov") |
There was a problem hiding this comment.
The testCoverage function below disables lcov in favor of the Go cover format, so this test can't pass.
Maybe move this info lcov_coverage_tests.go?
There was a problem hiding this comment.
lcov_coverage_tests.go already has this before #3294.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do? Why is it needed?
Adds tests for lcov merge integration provided by Bazel
Which issues(s) does this PR fix?
Fixes #3343
Other notes for review
#3294 contains the actual fix.
This PR creates tests.